From: Jon Hunter <jonathanh@nvidia.com>
To: Takashi Iwai <tiwai@suse.de>, Mark Brown <broonie@kernel.org>
Cc: <linux-tegra@vger.kernel.org>, <alsa-devel@alsa-project.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: soc-core: Prevent warning if no DMI table is present
Date: Wed, 3 Mar 2021 11:50:56 +0000 [thread overview]
Message-ID: <806466c4-4ef2-f4ba-3609-81b862810185@nvidia.com> (raw)
In-Reply-To: <s5hr1kxeah4.wl-tiwai@suse.de>
On 02/03/2021 17:23, Takashi Iwai wrote:
> On Tue, 02 Mar 2021 13:49:13 +0100,
> Mark Brown wrote:
>>
>> On Tue, Mar 02, 2021 at 09:27:12AM +0000, Jon Hunter wrote:
>>> Many systems do not provide a DMI table and on these systems a warning,
>>> such as the following, is printed on boot ...
>>>
>>> WARNING KERN tegra-audio-graph-card sound: ASoC: no DMI vendor name!
>>>
>>> If DMI support is enabled in the kernel, there is no simple way to
>>> detect if a DMI table is table or not. Note that the variable
>>> 'dmi_available' is not exported and so cannot be used by kernel modules.
>>
>> We could fix that, or provide an accessor function? Or only warn if
>> we're on an ACPI system (which we can check from a module). This really
>> does feel like something we should be warning about on systems that are
>> supposed to have DMI information available as standard.
>
> I had the same feeling when I took a look at the patch, but later
> changed mind, since the error will pop up also if a system has an
> unmatured BIOS with some bogus vendor DMI string, too. That is, users
> of such a machine gets always an error message although this isn't any
> serious problem unless you need a dedicated UCM profile (which can't
> be used on such a system in anyway).
>
> So, I agree that exporting dmi_avilable could improve the situation a
> bit, but the error level needs still reconsideration.
Thanks for the feedback. Yes it is probably better if we have a specific
test. I will send out a V2 for review.
Thanks
Jon
--
nvpublic
prev parent reply other threads:[~2021-03-03 16:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 9:27 Jon Hunter
2021-03-02 12:49 ` Mark Brown
2021-03-02 17:23 ` Takashi Iwai
2021-03-03 11:50 ` Jon Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=806466c4-4ef2-f4ba-3609-81b862810185@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®