From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0E0A2D5957 for ; Thu, 11 Dec 2025 22:08:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765490915; cv=none; b=jn4ZDY2yHEfFrXkKJLRzXA136u9Tv43dynEk8DrhZGVkgOFmqkTyTKulb9lgboaiTva6SrOIaaQOf79fosqjzq7Kr5EMrQXhIip3GmDlPTmMSC3eQuyCfK032NU5u2zanLC3VpqEeZ0R1tIrCBp0UAKVn9FbaurjvE7eiWtbiG4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765490915; c=relaxed/simple; bh=zjFf5L41tBDbcZuShBXTixXHD1C4nxZ3Q2igYRM27mY=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=Ki8M9D7x5MO9/nBm/EeWkxJctxXFUxPLLAhIzp2oPglB3VFQAml5VKvO2TeexGGDgA8un/VxiNXeEazI0iejphMQzdwNBfXMLBVnJnPnaWYENo5zZlqUjc3ZX9Ck9L8IFAMgCyOt7K/cnE+Ibbnu4ji+OmBc2LPon6ZF48pXhJE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=aKBw8+Ug; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=SrZNc2dh; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aKBw8+Ug"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="SrZNc2dh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765490913; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zjFf5L41tBDbcZuShBXTixXHD1C4nxZ3Q2igYRM27mY=; b=aKBw8+Ug/di1nowPoLHXjpU/wQv7XaWluU8P7EbB5pUwXb3hOPT4HoBKRBczuORjfTb2HY IHeMzfLn8DEXZiH9BIAD6UUWvrPpAno7p7IJ4B6pTOXilwhwHlH+P5fq3xeVgSds8Ps9KM JDUfd2UVPQ11tJm0cdVzeNFK+bSrjXM= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-269-hPSb4q4EMqy2NcmLSl2Fcw-1; Thu, 11 Dec 2025 17:08:31 -0500 X-MC-Unique: hPSb4q4EMqy2NcmLSl2Fcw-1 X-Mimecast-MFC-AGG-ID: hPSb4q4EMqy2NcmLSl2Fcw_1765490911 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-880441e0f93so15544776d6.1 for ; Thu, 11 Dec 2025 14:08:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1765490911; x=1766095711; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=zjFf5L41tBDbcZuShBXTixXHD1C4nxZ3Q2igYRM27mY=; b=SrZNc2dhlMf4hY81btUD6ku1vuIUfJ7binVAZCa2fm5S/QwyTgpwhM4KCTw131S+No mr80NKwlHrjEoSd2hCYxz0gpuxmr3JU1LJQD0EZ0lUPS53TpHZs3tAD37rzKBV6HyXOa x8m5IYAEb0T2kX7MqaBH7fGC0x152iCsjvwAKpKbH/70Zu4gYD7PF0lmH9BNpBBGaZp+ ZH9cuhJ1T7+lwnhVrZViT9cYG6oBgmQzF2KyOcfYvgOaP/zdEsuxfhfh4nXETtO0Z45Y C/Wh0R+jM2Y2A30RF5jzX10g2mVRZmVL4KL6nk5SmXhp2MJmEePvlIruAO8/EVYyvKaK KLig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765490911; x=1766095711; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zjFf5L41tBDbcZuShBXTixXHD1C4nxZ3Q2igYRM27mY=; b=pb3gU6zWXx3e+i0n4CTX0OB0klxokZar+471ReIM8sIUKO07AX7qMCINRdCX4+CpKg j+8/S8ePrMWKfoKvCkfKLgN1Se9zviscIwSJVNqVmZypDNXL/QM195UGd8j0/VAxsOKR 1h7RnTkqN4rytYIISicIIMCCtzG0sr9dBpZeeAm5BiDnVtvmGMq974XfRWVtCMfe5wNE Mtx22JYTOOdSnp3J1aRC3JWNDs0kxYUPbAtBH+fAWROfkvAmhxY7yBLQlg7aRZ7bBtcA WNgZFBn4RmiKRowudRQRzVDF9RdMPa41EKRPc7SAAQfdiKAh1Vku61hePesXBt6BHmtY 8m5A== X-Forwarded-Encrypted: i=1; AJvYcCXYQmxn3PcQn/vC50VmaRWeJ4vXJYIgyhVmmACC+nQ1ePQYBdXThpyWDO0Y0XfMbtJCQt3i9ryB5Zn4wss=@vger.kernel.org X-Gm-Message-State: AOJu0YxVTcupwcexxHjlkg1nsMklktYRgT9wpRozzRFYeGBs63GCVTXx nzrBthrMV7aiHVy0y0jU1WOQ3eA7+Ss6bnhtniitf5royyVOn4HLoreY2iO9qGPR3dUPL5MNJqs 81YsLSk9HBCzRe/dKmpNUp+HIlxkGUtnQc/5PgDBPngWSpvnq99T+tOrgMpNcNAO90Q== X-Gm-Gg: AY/fxX7xwJzvtE24etkMtYLOjfKvRuU4NbmHe14fzXXqjXXcfVquXuLcx9IZ5ftMCsa ZvFGGOTggsP/mK/AEizdlkIDeg9mcJJegLIW8EGA9Orv7ByxAgoV/my1c7PTFg8iThs+RQf4Klq 2nzmv8PmZjA+0fjRxbli2KCRWoukwFxl7G3cMhKbWFwvFQPD9WN8uOvMFZHJqHcUfISzCCIQWSN SDI/dmycESiMQNELi+uTM/zcvEGqrt1TaaEyO8783GEpu/Mg9Ee+GsA1jTmENsAOhfRBl7vCtxN S2EIzs60j09KYz4ofQLMayNE+PtLw4FUgnyzf3qaOVNWh2ixQRpVaJcGfIFzVL1UuaJXveB3s+f 3WO1muYX9yMcLDqmawp/0DN7cTA2ePIEby5mtLMlcdCTWdsbxqG3hFn0= X-Received: by 2002:a05:6214:5190:b0:888:4930:4c85 with SMTP id 6a1803df08f44-888715bbbdemr57238296d6.33.1765490911208; Thu, 11 Dec 2025 14:08:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IENTDQTVTO5abPiPnspbVewsjfe+HupVyKsPE/ZW6MQ2Op6oHfEVczT7wvjjsERpI1G70gtkQ== X-Received: by 2002:a05:6214:5190:b0:888:4930:4c85 with SMTP id 6a1803df08f44-888715bbbdemr57238006d6.33.1765490910860; Thu, 11 Dec 2025 14:08:30 -0800 (PST) Received: from [192.168.8.198] (pool-100-0-77-142.bstnma.fios.verizon.net. [100.0.77.142]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8886ef0d332sm35706406d6.45.2025.12.11.14.08.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 14:08:30 -0800 (PST) Message-ID: <8067808d2dda24ce27359e26653839a127eaa974.camel@redhat.com> Subject: Re: [PATCH 7/9] gpu: nova-core: firmware: fwsec: do not require bound device when unneeded From: lyude@redhat.com To: Alexandre Courbot , Danilo Krummrich , Alice Ryhl , David Airlie , Simona Vetter Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Edwin Peer , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org Date: Thu, 11 Dec 2025 17:08:29 -0500 In-Reply-To: <20251208-nova-misc-v1-7-a3ce01376169@nvidia.com> References: <20251208-nova-misc-v1-0-a3ce01376169@nvidia.com> <20251208-nova-misc-v1-7-a3ce01376169@nvidia.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reviewed-by: Lyude Paul On Mon, 2025-12-08 at 18:26 +0900, Alexandre Courbot wrote: > `run` doesn't require a bound device as its argument. >=20 > Signed-off-by: Alexandre Courbot > --- > =C2=A0drivers/gpu/nova-core/firmware/fwsec.rs | 7 +------ > =C2=A01 file changed, 1 insertion(+), 6 deletions(-) >=20 > diff --git a/drivers/gpu/nova-core/firmware/fwsec.rs > b/drivers/gpu/nova-core/firmware/fwsec.rs > index b28e34d279f4..b98b1286dc94 100644 > --- a/drivers/gpu/nova-core/firmware/fwsec.rs > +++ b/drivers/gpu/nova-core/firmware/fwsec.rs > @@ -412,12 +412,7 @@ pub(crate) fn new( > =C2=A0=C2=A0=C2=A0=C2=A0 } > =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0 /// Loads the FWSEC firmware into `falcon` and e= xecute it. > -=C2=A0=C2=A0=C2=A0 pub(crate) fn run( > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 &self, > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 dev: &Device, > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 falcon: &Falcon, > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bar: &Bar0, > -=C2=A0=C2=A0=C2=A0 ) -> Result<()> { > +=C2=A0=C2=A0=C2=A0 pub(crate) fn run(&self, dev: &Device, falcon: &Falco= n, > bar: &Bar0) -> Result<()> { > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 // Reset falcon, load th= e firmware, and run it. > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 falcon > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = .reset(bar)