From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3CAFC433FE for ; Tue, 18 Oct 2022 12:52:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230180AbiJRMw0 (ORCPT ); Tue, 18 Oct 2022 08:52:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229871AbiJRMwY (ORCPT ); Tue, 18 Oct 2022 08:52:24 -0400 Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2D8EC34CD for ; Tue, 18 Oct 2022 05:52:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=iX2U8THf+pquiaMR5M0K15dQE8WhWpHiv6AT0EQcZUY=; b=XknR4xUnCb36LgqEyYpiwSqxy0Urej3cmaVjBncToBcE5jEld1QWiBYx v0GiNugIsuobfs1zyW/ZeuC5hW48DxSjnTPUTIFrv4Kno0arfuaQqAEv0 jbV4nfUX8wbV9VT3Jf3toRTCcnvQLdvDymtLFR38lZj6YlHheifW7wL6Y c=; Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="5.95,193,1661810400"; d="scan'208";a="65749943" Received: from dt-lawall.paris.inria.fr ([128.93.67.65]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2022 14:52:21 +0200 Date: Tue, 18 Oct 2022 14:52:21 +0200 (CEST) From: Julia Lawall To: Deepak R Varma cc: outreachy@lists.linux.dev, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kumarpraveen@linux.microsoft.com, saurabh.truth@gmail.com Subject: Re: [PATCH v2] staging: most: dim2: read done_buffers count locally from HDM channel In-Reply-To: Message-ID: <80696861-c73f-cdb9-b4e1-36c29ece78bb@inria.fr> References: <1e2a71a9-4ac5-96f3-b875-a063ff62f3ad@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 18 Oct 2022, Deepak R Varma wrote: > On Tue, Oct 18, 2022 at 09:39:08AM +0200, Julia Lawall wrote: > > > > > > On Tue, 18 Oct 2022, Deepak R Varma wrote: > > > > > The done_buffer count is already available in the hdm_channel struct. > > > Calling dim_get_channel_state function to source this value out of > > > the same structure is unnecessary. > > > Further, the second parameter struct dim_ch_state_t to this function > > > is filled by using the hdm_channel inside the function. This filled in > > > variable is never used in the caller and can be altogether removed. > > > So, a call to dim_get_channel_state function in this context also > > > deems expensive. > > > > Thanks for the rewrite. > > > > I find "source this value out of" hard to understand. > > > > I would have written something like the following: > > > > The function dim_get_channel_state only serves to initialize the ready and > > done_buffers fields of the structure passed as its second argument. In > > service_done_flag, this structure is never used again and the only purpose > > of the call is to get the value that is put in the done_buffers field. > > But that value is just the done_sw_buffers_number field of the call's > > first argument. So the whole call is useless, and we can just replace it > > with an access to this field. > > > > This change implies that the variable st is no longer used, so drop it as > > well. > > This is really well written. Sounds much structured. Now my own log message > sounds a little random :) > > Is it okay for me to use your verbiage as is in my patch log? Yes. julia