From: Bart Van Assche <bvanassche@acm.org>
To: Hongling Zeng <zhongling0719@126.com>,
Hongling Zeng <zenghongling@kylinos.cn>,
Kai.Makisara@kolumbus.fi, James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com, djeffery@redhat.com,
jmeneghi@redhat.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: st: Fix lock leak in st_ioctl()
Date: Wed, 20 May 2026 09:25:07 -0700 [thread overview]
Message-ID: <806a798d-b2b6-489b-93e3-0fc54eaa14eb@acm.org> (raw)
In-Reply-To: <6A0D6825.8050902@126.com>
On 5/20/26 12:52 AM, Hongling Zeng wrote:
> The original code is correct. st_common_ioctl() releases &STp->lock
> internally, so there is no lock leak.
Indeed. See also the annotations in drivers/scsi/st.c in this patch
series: "[PATCH 00/36] Enable lock context analysis for most SCSI drivers"
(https://lore.kernel.org/linux-scsi/20260312211636.3245119-1-bvanassche@acm.org/).
Bart.
next prev parent reply other threads:[~2026-05-20 16:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 7:40 Hongling Zeng
2026-05-20 7:52 ` Hongling Zeng
2026-05-20 16:25 ` Bart Van Assche [this message]
2026-06-03 7:11 Hongling Zeng
2026-06-03 7:16 ` Hongling Zeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=806a798d-b2b6-489b-93e3-0fc54eaa14eb@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=Kai.Makisara@kolumbus.fi \
--cc=djeffery@redhat.com \
--cc=jmeneghi@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=zenghongling@kylinos.cn \
--cc=zhongling0719@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®