From: Andrew Lunn <andrew@lunn.ch>
To: Sky Huang <SkyLake.Huang@mediatek.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Daniel Golle <daniel@makrotopia.org>,
Qingfang Deng <dqfext@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Simon Horman <horms@kernel.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Steven Liu <Steven.Liu@mediatek.com>
Subject: Re: [PATCH net-next v2 2/5] net: phy: mediatek: Add token ring access helper functions in mtk-phy-lib
Date: Sun, 16 Feb 2025 17:47:42 +0100 [thread overview]
Message-ID: <8070a622-c6b8-4cf7-9845-ffa8b0478fb4@lunn.ch> (raw)
In-Reply-To: <20250213080553.921434-3-SkyLake.Huang@mediatek.com>
On Thu, Feb 13, 2025 at 04:05:50PM +0800, Sky Huang wrote:
> From: Sky Huang <skylake.huang@mediatek.com>
>
> This patch adds TR(token ring) manipulations and adds correct
> macro names for those magic numbers. TR is a way to access
> proprietary registers on page 52b5. Use these helper functions
> so we can see which fields we're going to modify/set/clear.
>
> TR functions with __* prefix mean that the operations inside
> aren't wrapped by page select/restore functions.
>
> This patch doesn't really change registers' settings but just
> enhances readability and maintainability.
>
> Signed-off-by: Sky Huang <skylake.huang@mediatek.com>
This is better, a bit smaller, but still pretty big. If you have made
a typo, and broken it, it is going to take a while to find it, no help
from git bisect.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2025-02-16 16:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 8:05 [PATCH net-next v2 0/5] net: phy: mediatek: Add token-ring helper functions Sky Huang
2025-02-13 8:05 ` [PATCH net-next v2 1/5] net: phy: mediatek: Change to more meaningful macros Sky Huang
2025-02-16 16:48 ` Andrew Lunn
2025-02-13 8:05 ` [PATCH net-next v2 2/5] net: phy: mediatek: Add token ring access helper functions in mtk-phy-lib Sky Huang
2025-02-16 16:47 ` Andrew Lunn [this message]
2025-02-13 8:05 ` [PATCH net-next v2 3/5] net: phy: mediatek: Add token ring set bit operation support Sky Huang
2025-02-16 16:48 ` Andrew Lunn
2025-02-13 8:05 ` [PATCH net-next v2 4/5] net: phy: mediatek: Add token ring clear " Sky Huang
2025-02-16 16:49 ` Andrew Lunn
2025-02-13 8:05 ` [PATCH net-next v2 5/5] net: phy: mediatek: Move some macros to phy-lib for later use Sky Huang
2025-02-16 16:49 ` Andrew Lunn
2025-02-18 0:30 ` [PATCH net-next v2 0/5] net: phy: mediatek: Add token-ring helper functions patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8070a622-c6b8-4cf7-9845-ffa8b0478fb4@lunn.ch \
--to=andrew@lunn.ch \
--cc=SkyLake.Huang@mediatek.com \
--cc=Steven.Liu@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®