mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Woody Suwalski <wsuwalski@gmail.com>
To: linux-pm@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Hans de Goede <hdegoede@redhat.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Subject: [PATCH] fix linux 5.16 freeze regression on 32-bit ThinkPad T40
Date: Wed, 9 Feb 2022 16:05:09 -0500	[thread overview]
Message-ID: <80742062-8629-3978-e78d-92ffc9bb2e0b@gmail.com> (raw)

From: Woody Suwalski <wsuwalski@gmail.com>

Add and ACPI idle power level limit for 32-bit ThinkPad T40.

There is a regression on T40 introduced by commit d6b88ce2, starting 
with kernel 5.16:

commit d6b88ce2eb9d2698eb24451eb92c0a1649b17bb1
Author: Richard Gong <richard.gong@amd.com>
Date:   Wed Sep 22 08:31:16 2021 -0500

     ACPI: processor idle: Allow playing dead in C3 state

The above patch is trying to enter C3 state during init, what is causing 
a T40 system freeze. I have not found a similar issue on any other of my 
32-bit machines.

The fix is to add another exception to the processor_power_dmi_table[] list.
As a result the dmesg shows as expected:

     2.155398] ACPI: IBM ThinkPad T40 detected - limiting to C2 
max_cstate. Override with "processor.max_cstate=9"
[    2.155404] ACPI: processor limited to max C-state 2

The fix is trivial and affects only vintage T40 systems.

Signed-off-by: Woody Suwalski <wsuwalski@gmail.com>
---
--- a/drivers/acpi/processor_idle.c    2022-02-04 09:09:54.515906362 -0500
+++ b/drivers/acpi/processor_idle.c    2022-02-04 14:21:08.264911271 -0500
@@ -96,6 +96,11 @@ static const struct dmi_system_id proces
        DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK Computer Inc."),
        DMI_MATCH(DMI_PRODUCT_NAME,"L8400B series Notebook PC")},
       (void *)1},
+    /* T40 can not handle C3 idle state */
+    { set_max_cstate, "IBM ThinkPad T40", {
+      DMI_MATCH(DMI_SYS_VENDOR, "IBM"),
+      DMI_MATCH(DMI_PRODUCT_NAME, "23737CU")},
+     (void *)2},
      {},
  };



             reply	other threads:[~2022-02-09 21:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-09 21:05 Woody Suwalski [this message]
2022-02-14 11:13 ` Hans de Goede
2022-02-16 17:20   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80742062-8629-3978-e78d-92ffc9bb2e0b@gmail.com \
    --to=wsuwalski@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®