From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752075AbdEDJB6 convert rfc822-to-8bit (ORCPT ); Thu, 4 May 2017 05:01:58 -0400 Received: from mail.kdab.com ([176.9.126.58]:34736 "EHLO mail.kdab.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751142AbdEDJBu (ORCPT ); Thu, 4 May 2017 05:01:50 -0400 From: Milian Wolff To: Jin Yao Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v1 2/2] perf report: Display titles in left frame of annotate browser Date: Thu, 04 May 2017 11:01:48 +0200 Message-ID: <8076707.4PSiRuChLW@milian-kdab2> Organization: KDAB In-Reply-To: <1493909895-9668-3-git-send-email-yao.jin@linux.intel.com> References: <1493909895-9668-1-git-send-email-yao.jin@linux.intel.com> <1493909895-9668-3-git-send-email-yao.jin@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, May 4, 2017 4:58:15 PM CEST Jin Yao wrote: > The annotate browser is divided into 2 frames. Left frame > contains 3 columns (some platforms only have one column). > > For example: > > │26 int compute_flag() > │27 { > 22.80 1.20 │ sub $0x8,%rsp > │25 int i; > │ > │27 i = rand() % 2; > 22.78 1.20 1 │ → callq rand@plt > > While it's hard for user to understand what the data is. > > This patch adds the titles "Percent", "IPC" and "Cycle" > on columns. > > Percnt IPC Cycle │ > │25 __attribute__((noinline)) > │26 int compute_flag() > │27 { > 22.80 1.20 │ sub $0x8,%rsp > │25 int i; > │ > │27 i = rand() % 2; > 22.78 1.20 1 │ → callq rand@plt > > The titles are displayed at row 0 of annotate browser if row 0 > doesn't have values of percent, ipc and cycle. Functionality wise a really good improvement - thanks! But personally I find the abbreviation of one character (i.e. "Percnt" instead of "Percent") not so nice. If space really is an issue here, use "%"? Also note though that it's unclear what this percentage actually is. I guess it's a sample percentage? Maybe a header should be added that explains these values to newbies. I bet many people won't even know what IPC is either. Cheers -- Milian Wolff | milian.wolff@kdab.com | Software Engineer KDAB (Deutschland) GmbH&Co KG, a KDAB Group company Tel: +49-30-521325470 KDAB - The Qt Experts