From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"jin.xiao@intel.com" <jin.xiao@intel.com>,
"axboe@kernel.dk" <axboe@kernel.dk>
Cc: "yanmin.zhang@intel.com" <yanmin.zhang@intel.com>,
"tom.leiming@gmail.com" <tom.leiming@gmail.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"ming.lei@redhat.com" <ming.lei@redhat.com>
Subject: Re: [PATCH] block: blk_init_allocated_queue() set q->fq as NULL in the fail case
Date: Mon, 30 Jul 2018 13:42:13 +0000 [thread overview]
Message-ID: <80814c1eac9d8dda424d6c96652bd13d0ea30726.camel@wdc.com> (raw)
In-Reply-To: <1532931072-5190-1-git-send-email-jin.xiao@intel.com>
On Mon, 2018-07-30 at 14:11 +0800, xiao jin wrote:
> We find the memory use-after-free issue in __blk_drain_queue()
> on the kernel 4.14. After read the latest kernel 4.18-rc6 we
> think it has the same problem.
>
> Memory is allocated for q->fq in the blk_init_allocated_queue().
> If the elevator init function called with error return, it will
> run into the fail case to free the q->fq.
>
> Then the __blk_drain_queue() uses the same memory after the free
> of the q->fq, it will lead to the unpredictable event.
>
> The patch is to set q->fq as NULL in the fail case of
> blk_init_allocated_queue().
Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com>
next prev parent reply other threads:[~2018-07-30 13:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 6:11 xiao jin
2018-07-30 12:06 ` Ming Lei
2018-07-30 13:42 ` Bart Van Assche [this message]
2018-07-30 14:28 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80814c1eac9d8dda424d6c96652bd13d0ea30726.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=axboe@kernel.dk \
--cc=jin.xiao@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tom.leiming@gmail.com \
--cc=yanmin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®