From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932366AbcDGVY6 (ORCPT ); Thu, 7 Apr 2016 17:24:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40442 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757447AbcDGVY4 convert rfc822-to-8bit (ORCPT ); Thu, 7 Apr 2016 17:24:56 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20160407.165021.1271761992369838408.davem@davemloft.net> References: <20160407.165021.1271761992369838408.davem@davemloft.net> <1460046677.6715.95.camel@perches.com> <1091.1460058308@warthog.procyon.org.uk> <5702.1460062039@warthog.procyon.org.uk> To: David Miller Cc: dhowells@redhat.com, joe@perches.com, linux-afs@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled. MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <8081.1460064293.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Thu, 07 Apr 2016 22:24:53 +0100 Message-ID: <8082.1460064293@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Miller wrote: > As you can with the function tracer and tracepoints. I've had experience with tracepoints before (i2c and smbus). It wasn't particularly fun. There's got to be some easier way to write them. Hmmm... Of the _enter() and _leave() macros in my tree at the moment, I have 261 that record more information than just the name of the function. I presume each would need to be converted to a TRACE_EVENT*() macro as, as far as I can see with a cursory examination, the function tracer doesn't record arguments or the things arguments point to (which I do a lot of). There are also another 84 of these macros that only record the name of the function which are simpler propositions. Add to that 286 _debug(), _net() and _proto() macros, all of which record more information than just the name of the calling function and don't have anything particularly to do with function trace. Now, I have been considering that the _net() and _proto() macros would probably work well as TRACE_EVENT()-type constructs, allowing the tracing of protocol flow. I don't suppose you have a script for automatically converting something like a printk()-type thing into a TRACE_EVENT()? David