From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F8AC302150 for ; Wed, 19 Nov 2025 20:28:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763584147; cv=none; b=lOcvi+EZgKWiVLY7VEg2bhDsmzOlyH9IHdKvhZWYq+O0rcM6nB1RdNRbo6g5Yw5cZOWn4V2ilnQ1OTfzkdl5NuzTwHw6nzUmi49zSVipfoXkFBR2sH+VHy9zo/mg2tnirl4ARZECy4Nb1XIDRpyjlcxbN28pM8wlCKuG8r55Ayg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763584147; c=relaxed/simple; bh=g/pK8ZLLGLzMcWkMe0ugqHmKKZyS10imeG122WSdOWo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EtQYk9EXHJCKdrIfZgk2ISrXGiHmE52d1OsoYm6U12Xgv0UF7Gd7s6SFnTGOLZNJR+gtQlpi6PanykcezXu1Q6stCgC+unIEbpPaWJY/VFHdPdzv0ICl6tyuVDbyH+3gXTFTsvbTkzOFa240Zp+f38AkelJqGuH2bLo64ZmWdq4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DA4bGn/i; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=a9abKZ6P; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DA4bGn/i"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="a9abKZ6P" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AJJclB62266892 for ; Wed, 19 Nov 2025 20:28:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dPnM840VJFPRltzXDqsgZKK11L3FNwTK+BhD/jqFmsc=; b=DA4bGn/i6Ly6n5/E s/7EcVXBgz0RBD/u+26qrEt1SBceoQ7v5W5Kr2lUmjiqHCkIRSbiqEgpWrki8jsz KhjsZXUBNgb3/c4tDJhtN6oLT9ZKGO0S7tGoOtDN9g9G6qhlUqU60mgZmZrbOoOR W/S5CTuP23tLjRFyfUM5ifChMGUJ6Ns3D9KGKUSr03QN178zib1SlIfu8fkIg4Gm L1RKsoiq9Ss6bwVcd69imAFvo+hUs69F3/ZbZ410mL4pLR2Z6d9H8Xc0V7tmnnVn epgjbw6wDpIU6op+rba9/8hO6pJvTB6vD2SEomFsCJi1WaCssAL5wnMxZeJ/8J+s 4nTQCA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ahm8104b2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 19 Nov 2025 20:28:54 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4ed6e701d26so3540031cf.1 for ; Wed, 19 Nov 2025 12:28:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763584134; x=1764188934; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dPnM840VJFPRltzXDqsgZKK11L3FNwTK+BhD/jqFmsc=; b=a9abKZ6P3siQdHQbAE9T8xXgRapW3qhC4Wj4+DtwljOBaJB1gQq/afw5jbwrED9TYF QKmjlik2YAELlOhH276GKVMTUR6rcZR/qlXAp/6OXLiZpt/gcDZgIPnh1sN2Yhy7ID+i 16icDu42ovFUA680GR4YXjAuNoyb+m9+/kStQu/yoADJ1fD++cdonEFNwytPHF9u/fBK roY1Qor/QtAgq1qV0Z+xlXJy9Zunb58XUhg7zJipd8ViWQMYPV4Z/Kok2K7lgrn6q4sw bHZ4WyDFUkwr2qpA+3V6jbVclq7vvU0CJ8oR7TagcNs/c5dKciphf8E73k2chDLn/q0H ndhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763584134; x=1764188934; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dPnM840VJFPRltzXDqsgZKK11L3FNwTK+BhD/jqFmsc=; b=txBZun7apN3XpP9rdJ8L0Iv1S5mqe31GNAAn3EoBXtIGrrUoe7CRTCG37TKP59O3fN m8cDfgOh6/WxzrCaVMNKa5gR8MHHVTpTBNe1vv3tBq3EkfeykmlZfy/Z2S3QerF+cLP4 2GhelQjQ6/U4It5DlCeyvcOkK8ldioEoq5mZSdGUQU3FsHe4xuFMZsok2K9tErysMFcT If9t43xqVcZ4koHqkdeFTAMfpSUgS1R+fUirrbtN3pxzA2lceNpdQlqu1TFE2DeG9CKu dx4wYeS4Ckq6lVh1Mhhn1QVVCWqmaYzuHZssMgORR9Hv/NBkoJcgc4xWzyWHXz0zyvhZ D1Yw== X-Forwarded-Encrypted: i=1; AJvYcCV7hTC37hW1rHKTb1zQhHXnr2lmBj2Tpsd7sVj0ji2GRlAwWz6snu70di7Sxjju+MBZzAWip2E2caV+wiI=@vger.kernel.org X-Gm-Message-State: AOJu0YyM56JW0NmjC0daPfc0Wcig2Q9RioCeOFHmHGUlqH0tKBGm3AsA Lh3b1+vS/Vu2KU+/OVofBMhU90tnRcyOBEToj3cOwQ7H2EBb0yv9VrLhnGL/BxTx1/uo8YhNE73 3n3GSSl6YHghMW9sZNQzemL4N5RekAufwExQogotCl49MY+zV2h57vuCzIXIE68aG/OM= X-Gm-Gg: ASbGncu46pzm6scTmjN8swFzaho65HwWVBgWw+nA8D9EU3TE9ysraxzzr6wSayejuXH FgRp+KKm8vGE2UOIHw+fIKnHjBejYKgkmc1zPrgEV0Awwv50SjXRawborxSmv6D98TlvlX3Wbtl ce83FnB+C4x5v+piWgYDQSFgbGir6Pbh5aKCUUsk9u3BDtalnc8SIFOKk/hJUKtt4218sNCaGDx LEdb/CRLEjR4i+pHEg+TvGqcHJ0wncq4oFpQdE3Jik0h7WW9CCwggGoi+XuRPHctqgkJLHyXzMu 9Va6fTH3OrXrkS/HYFQBhcfChVa4epEz7xTyAWvFPER3pMgiJQjAOhA7Q5IptHSNpHeTIVq/1x5 lN4dhREbeHfWBFNchu8uEoHb4eqozznHc5WRY X-Received: by 2002:ac8:5e0a:0:b0:4ee:24e8:c9b6 with SMTP id d75a77b69052e-4ee4a09bdcemr5262031cf.59.1763584133584; Wed, 19 Nov 2025 12:28:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IFOXKTjfsFE02TAa3utoPP4wwivftCiEZk8Oiy72azJqAD3Dza9t6k70sbNo+T2C2pKvCDD9g== X-Received: by 2002:ac8:5e0a:0:b0:4ee:24e8:c9b6 with SMTP id d75a77b69052e-4ee4a09bdcemr5261631cf.59.1763584133087; Wed, 19 Nov 2025 12:28:53 -0800 (PST) Received: from [192.168.68.121] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-42cb7fb8a29sm1035717f8f.30.2025.11.19.12.28.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Nov 2025 12:28:52 -0800 (PST) Message-ID: <80836b8f-16a8-4520-ad11-5ca0abb3403e@oss.qualcomm.com> Date: Wed, 19 Nov 2025 20:28:50 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] arm64: dts: qcom: sdm630/660: Add CDSP-related nodes To: Konrad Dybcio , Nickolay Goppen , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ekansh Gupta Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, linux@mainlining.org References: <20251023-qcom-sdm660-cdsp-adsp-dts-v2-0-895ffe50ab5f@mainlining.org> <20251023-qcom-sdm660-cdsp-adsp-dts-v2-1-895ffe50ab5f@mainlining.org> <07066c46-4121-48da-846a-3a180d245589@oss.qualcomm.com> <47b40a91-8365-4431-9fd9-1e48fad2a4e1@mainlining.org> <83c3aea5-764e-4e60-8b16-67b474f19357@oss.qualcomm.com> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: JPkVu-mCzwX7rm2RyXLZwPyK8oGn-i43 X-Proofpoint-GUID: JPkVu-mCzwX7rm2RyXLZwPyK8oGn-i43 X-Authority-Analysis: v=2.4 cv=SJ5PlevH c=1 sm=1 tr=0 ts=691e2886 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=OuZLqq7tAAAA:8 a=dCnKVPZACBjga27198AA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=AKGiAy9iJ-JzxKVHQNES:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTE5MDE2MCBTYWx0ZWRfXxeUviagz18Xn EL9i6bDXz3rTkxzTADp+cxdMKS6SwDdaiRS3iymf7BVkHFHwsKuF27QvLnRq5IvxNaDGFwmekZ5 RWKPJClqPHi1FTdok0Z/60MMIQdpsvPb6l+ckJ2GZkAoAaQJLX1R9PrPHnb7Ha2lMaCdfr6bmjt FF3NjBScidNwkcea1D4XDKTDCcFcOw3DGqqVNkEUccTnRxVXKVdBPHkNLLsd7sEiHVoO+sof+/O un/9K89K24oSvNKUmJOILu4hYcn/1E/zh3CzPF+RhY0oFgIUgO9aKjmjRCFlY5XUgwES/dhz36J j3cbFbor7QqLnAB/2mRd784JCcqO/i4YdhBA1tqTs9bYL/eF/zxG9WXrNPn0/oNv/ZJJhq05mYw DuFaoOS3/aYc5/lzwVfuenEWCAsF7Q== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-19_06,2025-11-18_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 adultscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511190160 On 11/12/25 1:52 PM, Konrad Dybcio wrote: > On 11/10/25 6:41 PM, Srinivas Kandagatla wrote: >> On 11/3/25 12:52 PM, Konrad Dybcio wrote: >>> On 10/31/25 12:30 PM, Nickolay Goppen wrote: >>>> >>>> 24.10.2025 16:58, Nickolay Goppen пишет: >>>>> >>>>> 24.10.2025 11:28, Konrad Dybcio пишет: >>>>>> On 10/23/25 9:51 PM, Nickolay Goppen wrote: >>>>>>> In order to enable CDSP support for SDM660 SoC: >>>>>>>   * add shared memory p2p nodes for CDSP >>>>>>>   * add CDSP-specific smmu node >>>>>>>   * add CDSP peripheral image loader node >>>>>>> >>>>>>> Memory region for CDSP in SDM660 occupies the same spot as >>>>>>> TZ buffer mem defined in sdm630.dtsi (which does not have CDSP). >>>>>>> In sdm660.dtsi replace buffer_mem inherited from SDM630 with >>>>>>> cdsp_region, which is also larger in size. >>>>>>> >>>>>>> SDM636 also doesn't have CDSP, so remove inherited from sdm660.dtsi >>>>>>> related nodes and add buffer_mem back. >>>>>>> >>>>>>> Signed-off-by: Nickolay Goppen >>>>>>> --- >>>>>> [...] >>>>>> >>>>>>> +            label = "turing"; >>>>>> "cdsp" >>>>> Ok, I'll change this in the next revision. >>>>>>> +            mboxes = <&apcs_glb 29>; >>>>>>> +            qcom,remote-pid = <5>; >>>>>>> + >>>>>>> +            fastrpc { >>>>>>> +                compatible = "qcom,fastrpc"; >>>>>>> +                qcom,glink-channels = "fastrpcglink-apps-dsp"; >>>>>>> +                label = "cdsp"; >>>>>>> +                qcom,non-secure-domain; >>>>>> This shouldn't matter, both a secure and a non-secure device is >>>>>> created for CDSP >>>>> I've added this property, because it is used in other SoC's, such as SDM845 and SM6115 for both ADSP and CDSP >>>> Is this property not neccessary anymore? >>> >>> +Srini? >> >> That is true, we do not require this for CDSP, as CDSP allows both >> unsigned and signed loading, we create both secured and non-secure node >> by default. May be we can provide that clarity in yaml bindings so that >> it gets caught during dtb checks. >> >> >> However in ADSP case, we only support singed modules, due to historical >> reasons how this driver evolved over years, we have this flag to allow >> compatiblity for such users. > > Does that mean that we can only load signed modules on the ADSP, but > the driver behavior was previously such that unsigned modules were > allowed (which was presumably fine on devboards, but not on fused > devices)? Yes, its true that we allowed full access to adsp device nodes when we first started upstreaming fastrpc driver. irrespective of the board only signed modules are supported on the ADSP. I think there was one version of SoC i think 8016 or some older one which had adsp with hvx which can load unsigned modules for compute usecase only. I have added @Ekansh for more clarity. --srini > > Konrad