From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 013.lax.mailroute.net (013.lax.mailroute.net [199.89.1.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B853233DEDF; Fri, 19 Dec 2025 21:06:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=199.89.1.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766178380; cv=none; b=BgkF7nPTFRQJeCyDdMHK0jWCYhQABNvtWix3kU3QUauKddZhFWRPf6zBMS1A7sHGAtdjnNruZ6N4tAGcqQoWyOT3KyocflLl4jy71/H6dItTcirJfe5Gij3qohsnay4SG8J+lgVycjy2G9aQ9/CDq/20Y/5XygEdB/vvc0zimuw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766178380; c=relaxed/simple; bh=KbLUB8IaJRvBl5lXgJ7Cs0r+YarnKCWMUwz4SWOikvM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WjeLFpt/FTEWgypD0M4Rp0ZvMqyTcF+KJSZL4vmi6/+ilgML7wuTyr7Z4oN1zOo0sySJROcTJYxfgh/4nvef3b3T9CMmXw97FGMXD8O+M6CdNJPEyzJZhQoueQSp4wjWGbmuANTng3rYhrs7e3/fhho3AQIlGSw+hHecuqoiOg0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org; spf=pass smtp.mailfrom=acm.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b=biL2fFLA; arc=none smtp.client-ip=199.89.1.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=acm.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b="biL2fFLA" Received: from localhost (localhost [127.0.0.1]) by 013.lax.mailroute.net (Postfix) with ESMTP id 4dY0Sp0FgnzlwqPk; Fri, 19 Dec 2025 21:06:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:content-language:references:subject:subject :user-agent:mime-version:date:date:message-id:received:received; s=mr01; t=1766178370; x=1768770371; bh=smhZ+HMOPx/2qzqSsA1Ia7Ur +56UUYwNTrJDmSp3Lho=; b=biL2fFLApXPBmQ8TkRiQaN7joqG7DMeHj6mylEkD tBlkgGUzRoC9PLYlhABCpwHU2kS/gcSVCoHuSawmvmv9A+1ZB6+DzaHAtAtJr0Vy Gaw2/ivM9zN+LSh5+NNmhdaNX0vgalSYo7eljPfVpvrgPReDXQnD4sdGtTGVaz9z Umt7RruBkXjgNb6vOZRtw7fRLVHhFXClAviuwN2fuGGoSbXWAzM1RGdqWYqf2Gnq lkb7sLgp+Rc36kuO9w/2+dhSaDlkra7TX68tuxqKu4/a6scJfx5XonCslZVz57gx Ubj0Ir+QQt9kHEnwxXlB8oeIRqIUDvcEmp3KYmWisFVRDw== X-Virus-Scanned: by MailRoute Received: from 013.lax.mailroute.net ([127.0.0.1]) by localhost (013.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id EEu5ZjhUq7eo; Fri, 19 Dec 2025 21:06:10 +0000 (UTC) Received: from [100.119.48.131] (unknown [104.135.180.219]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 013.lax.mailroute.net (Postfix) with ESMTPSA id 4dY0SP39w9zllB6t; Fri, 19 Dec 2025 21:05:57 +0000 (UTC) Message-ID: <8086c568-9386-4231-b928-3e887c8679b4@acm.org> Date: Fri, 19 Dec 2025 13:05:56 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 22/36] um: Fix incorrect __acquires/__releases annotations To: Marco Elver , Peter Zijlstra , Boqun Feng , Ingo Molnar , Will Deacon Cc: "David S. Miller" , Luc Van Oostenryck , Chris Li , "Paul E. McKenney" , Alexander Potapenko , Arnd Bergmann , Christoph Hellwig , Dmitry Vyukov , Eric Dumazet , Frederic Weisbecker , Greg Kroah-Hartman , Herbert Xu , Ian Rogers , Jann Horn , Joel Fernandes , Johannes Berg , Jonathan Corbet , Josh Triplett , Justin Stitt , Kees Cook , Kentaro Takeda , Lukas Bulwahn , Mark Rutland , Mathieu Desnoyers , Miguel Ojeda , Nathan Chancellor , Neeraj Upadhyay , Nick Desaulniers , Steven Rostedt , Tetsuo Handa , Thomas Gleixner , Thomas Graf , Uladzislau Rezki , Waiman Long , kasan-dev@googlegroups.com, linux-crypto@vger.kernel.org, linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-sparse@vger.kernel.org, linux-wireless@vger.kernel.org, llvm@lists.linux.dev, rcu@vger.kernel.org, kernel test robot , Johannes Berg , Tiwei Bie References: <20251219154418.3592607-1-elver@google.com> <20251219154418.3592607-23-elver@google.com> Content-Language: en-US From: Bart Van Assche In-Reply-To: <20251219154418.3592607-23-elver@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/19/25 7:40 AM, Marco Elver wrote: > -void enter_turnstile(struct mm_id *mm_id) __acquires(turnstile) > +struct mutex *__get_turnstile(struct mm_id *mm_id) > { > struct mm_context *ctx = container_of(mm_id, struct mm_context, id); > > - mutex_lock(&ctx->turnstile); > + return &ctx->turnstile; > } Many "container_of()" wrappers have "to" in their name. Please follow that convention and rename this function into e.g. mm_id_to_turnstile(). Thanks, Bart.