From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 226D5EB64DD for ; Wed, 5 Jul 2023 06:21:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231604AbjGEGVl (ORCPT ); Wed, 5 Jul 2023 02:21:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231575AbjGEGVh (ORCPT ); Wed, 5 Jul 2023 02:21:37 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41ACB10E3 for ; Tue, 4 Jul 2023 23:21:35 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-51d9850ef09so7494527a12.0 for ; Tue, 04 Jul 2023 23:21:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688538094; x=1691130094; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WXzJTSL0C9SwjgGDM+8y6l17lgOMSjsuE+XiEFarJNk=; b=JDdijNyMs8YO+LoLmY4HtiDvBobZ9JptXvaqMkpbUBszqzxc6cq82TNPImNYZaxV+Z qVgDrM42GC+z+i/lDPscyQIdo7LhRdC/XvFuhUzJABKTlViN2SA12Fcz8cgdPk461T5h kDkzai8vvYJh1JE9gbcmeO2YwOtODRh0hIKYCxfH3VBrBTzYbbsX0BIMNfhe0aS4nqYm UVM2Efp07zXFMmzkeJj47bifN4lnYOc5ynTauIMCGQFABMTTmPb3FVyUvlgmLMGL6KX/ tJSBpp3ci2IU9TOPefsDNkNGDmnasJL0Yk7WfUeBpJqqcsXf97ZIQnM0XmF245GpqUoK r3rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688538094; x=1691130094; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WXzJTSL0C9SwjgGDM+8y6l17lgOMSjsuE+XiEFarJNk=; b=DHguIxaOCkWFJboWZmlKhmM8X6+Vfm3N7LfkBjg1DAfNQcjEVCMKBwJyF1kAangvQq LbpxlaMW61ncIxOJp5msvk21YjVXCrN5Hf1mPIU7wq0UOIy3ODrCCoddzOhQTxw+4sdE b2X+S6INtgk+4ebeYllJVgsAirRPa8varcVJQbVz2mR8wC0kOeg+YWz+NF2JopzZQhP9 CNYPttR2gXRVOIXQf8klk1xYt/rHMCZTLLnlUG0uYXtyPa6j25AE4RMJSzm6pPlHNu14 gw42CMYHMLVvfj39VFTSxHlmm+S00GMNSkKCXVQIN9ITVNk/TAXZhUjmmhOQ7g6MXjOm cLtQ== X-Gm-Message-State: ABy/qLbPRNHvVVWFM8m8whDI9V8HtmtQGMu1NOb0bYYmUJUBmNhMbYcC kNd5iPTneyuSbpMSNi+6oqBNDdJrLa/PbGZc0Lw= X-Google-Smtp-Source: APBJJlExSLHdFgXPPpShsvfpLnQ1I9K6lq+Cv1kUvCmlpBxjhMhTXaJcgj6YoR1Z3h3+qYtEpvI1Ow== X-Received: by 2002:a17:906:4f0a:b0:965:9602:1f07 with SMTP id t10-20020a1709064f0a00b0096596021f07mr11480125eju.39.1688538093774; Tue, 04 Jul 2023 23:21:33 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id e8-20020a1709062c0800b0098822e05539sm14050847ejh.191.2023.07.04.23.21.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jul 2023 23:21:33 -0700 (PDT) Message-ID: <808dac44-a72c-4675-1e4a-0ed96190efb4@linaro.org> Date: Wed, 5 Jul 2023 08:21:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v4 2/3] spi: cadence-quadspi: Add clock configuration for StarFive JH7110 QSPI Content-Language: en-US To: William Qiu , devicetree@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Cc: Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Emil Renner Berthing , Ziv Xu References: <20230704090453.83980-1-william.qiu@starfivetech.com> <20230704090453.83980-3-william.qiu@starfivetech.com> From: Krzysztof Kozlowski In-Reply-To: <20230704090453.83980-3-william.qiu@starfivetech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/07/2023 11:04, William Qiu wrote: > Add QSPI clock operation in device probe. > > Signed-off-by: William Qiu > Reviewed-by: Hal Feng > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202306022017.UbwjjWRN-lkp@intel.com/ > Reported-by: Julia Lawall > Closes: https://lore.kernel.org/r/202306040644.6ZHs55x4-lkp@intel.com/ > > @@ -1840,6 +1858,8 @@ static int cqspi_resume(struct device *dev) > struct spi_master *master = dev_get_drvdata(dev); > > clk_prepare_enable(cqspi->clk); > + if (of_device_is_compatible(dev->of_node, "starfive,jh7110-qspi")) Don't add compatible checks inside the code. It does not scale. We expect compatibles to be listed only in one place - of_device_id - and customize driver with match data / quirks / flags. Comment applies to all your diff hunks. > + clk_bulk_prepare_enable(cqspi->num_clks, cqspi->clks); > cqspi_wait_idle(cqspi); > cqspi_controller_init(cqspi); > Best regards, Krzysztof