From: Shuah Khan <skhan@linuxfoundation.org>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
"Mark Brown" <broonie@kernel.org>
Cc: kernel@collabora.com, Jaroslav Kysela <perex@perex.cz>,
Shuah Khan <shuah@kernel.org>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2] kselftest/alsa: Increase kselftest timeout
Date: Wed, 14 Dec 2022 09:40:02 -0700 [thread overview]
Message-ID: <808f35bf-2800-c34b-cae9-4d8eaa11294d@linuxfoundation.org> (raw)
In-Reply-To: <20221214130353.1989075-1-nfraprado@collabora.com>
On 12/14/22 06:03, Nícolas F. R. A. Prado wrote:
> The default timeout for kselftests is 45 seconds, but that isn't enough
> time to run pcm-test when there are many PCMs on the device, nor for
> mixer-test when slower control buses and fancier CODECs are present.
>
> As data points, running pcm-test on mt8192-asurada-spherion takes about
> 1m15s, and mixer-test on rk3399-gru-kevin takes about 2m.
>
> Set the timeout to 4 minutes to allow both pcm-test and mixer-test to
> run to completion with some slack.
>
> Reviewed-by: Mark Brown <broonie@kernel.org>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>
> ---
>
> Changes in v2:
> - Reduced timeout from 10 to 4 minutes
> - Tweaked commit message to also mention mixer-test and run time for
> mixer-test on rk3399-gru-kevin
>
What I have in mind is that the default run can be limited scope.
Run it on a few controllers and in the report mention that a full
test can be run as needed.
There are a couple of examples of default vs. full test runs - cpu
and memory hot-lug tests.
thanks,
-- Shuah
next prev parent reply other threads:[~2022-12-14 16:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 13:03 Nícolas F. R. A. Prado
2022-12-14 16:40 ` Shuah Khan [this message]
2022-12-14 18:15 ` Mark Brown
2023-04-03 21:30 ` Nícolas F. R. A. Prado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=808f35bf-2800-c34b-cae9-4d8eaa11294d@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=nfraprado@collabora.com \
--cc=perex@perex.cz \
--cc=shuah@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®