From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A7464C96 for ; Mon, 20 Jan 2025 08:46:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737362789; cv=none; b=Y8q/7XNSxg4YdOYg1hNBbBmeMxw2+AabrjI1KymC83rvlXxSddLM2FP7zRDWzDliYgbkX+rapEXas1UuKt2U/QrIIOdbb7vucEF3xQWez8A2KaEZr/EJ20/rx7qtJT/Kw56lE6eoZN/S4tXyAJzJRXMBKENxj2efA5ioXRie2g0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737362789; c=relaxed/simple; bh=zUeijhfwW4s+q2BsWuBbnh7bJhrilCzjEf5+dfm3WLo=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=QANU8XMK+hBe8BFohHfk+XVKEeNreg7x+YQJJ6w1tLyJq65n7OxVteko8yhdYJLJwCxdqrLk6yxOHiF9qlTzvNu+sVFx4SqkghXFnfhENHxyxOTadPG/fk3hSq4NAV0HTGqUbK5qH6k5gYqW42CjfFQzZbfQjRaa0htd+QVbtgU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Y8HNr/xF; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Y8HNr/xF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737362786; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EcZJYBt+kfHbCBrPq6yoGjB/TV1vhufPJ1NBpXI8Qkg=; b=Y8HNr/xFcfOSAmb3vYi1eM0dInQxVe+MMJFbwPLAR54AMEGI4jbSve2wtOx7LaoUpY8c6E z3r+phlH87URFZOBwwmoID1l/dd4eCT1IGGe9jVQAuMZcrw5VlpKuqqlsB1s7cZbWVKHw1 cYzQe/Xqy2nJjb7Dyt7pUNaZmLmn8XQ= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-655-nSrABeJBNsSee03MsGfA3g-1; Mon, 20 Jan 2025 03:46:24 -0500 X-MC-Unique: nSrABeJBNsSee03MsGfA3g-1 X-Mimecast-MFC-AGG-ID: nSrABeJBNsSee03MsGfA3g Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3862e986d17so1736485f8f.3 for ; Mon, 20 Jan 2025 00:46:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737362783; x=1737967583; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=EcZJYBt+kfHbCBrPq6yoGjB/TV1vhufPJ1NBpXI8Qkg=; b=Vbcq3TsKLF/p44NBsZlh+TxXjF1+wCnWDBaqU/36NDB7tUaOSB3c/31I+8GdG2qmyX b1MEuRn2C5OkT9mHub/7dG8ytlFeOn4z1nZD/CU5b/FQmQ2Fo4T3qKON2in65CebIZYb 7OBZJ9Ocmo6qxzDNiQzG0UMaDH0oEujwqNF3k4zpIYlO23mXd14gLtfP22HrREIF/yTY RiTzYHuecbuumijVTt7cAF/TBjOZUrJSte7E1KJKkecHasipHQwuTJq9YXyXU+Hxoin/ KKJGrNjWQ4HjrMNoSXb4oLVevW3BY+jb0h0dxJJ39rRioejWQAoPyu4Z9uUXmP95U8oz HSKg== X-Forwarded-Encrypted: i=1; AJvYcCUKf6a6QhIxmcebsCX0UmpD+GKHFH93EEzmzOj845coSIHsrRryMex7L0AE3RCffMDR727d7IK1PbZhXns=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/SbjtJ0HhK2symaEseIMQXXbA86snRIBksm2sShlAHe4m1FqW T5Sx45vVLNGVnzBgEatFRLJiYCsWrm3ovTQiXuN+yvv1PR/tGaybkrcxOO9kYKkD7s3yK/Y1f8M amkDl3WXTY7tK65D7Mma5uPjOJOPwlO0AWPaMuU32f8TsDAIw4Ft01cSJOcjm4g== X-Gm-Gg: ASbGncvb7AkbT0tmZ/4SaRySoqz6v3+9xMlg8k89tLa1539sdVhabxsW9IVJb0TWgLN uMty+L1z7ih6X/OPsY9vSane3Q0PSiNSowAJ1y01vEW1ynmGiHEDWDdSJCDT+KAFeMPPCy1/tIf zR8Pn+z1+NX7e8+S7tJ4gl1iv2q3q93ro/QNa92aX6JiBueyj+KR/HGpqdI70tPbVK49LwBf9OH y8lpAo4cQLgXl3x6eBf+73OZz5IAQXG+BL3B5nfxNDEU+86wAQRUxtsH2D2klaNqvcdMCsrQhYo OtVEgoPjDcgg4DWiwvOvD07XZbunLYH2qf2RnfNHEuOAZ/e7WLcS9JUP7zhzJIFbzOzWLPIedgK M1/7bv0Rda01bJG8KasUZLA== X-Received: by 2002:a05:6000:4012:b0:38a:9f27:838c with SMTP id ffacd0b85a97d-38bf57ce8b8mr10993324f8f.55.1737362783185; Mon, 20 Jan 2025 00:46:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IHEQMS5mdpP/VrXUAomKeHTh7+Ip5YpnfPTakpnnTuYFZI8f5sBYOwjj1pFBHYloWKmZPOfxg== X-Received: by 2002:a05:6000:4012:b0:38a:9f27:838c with SMTP id ffacd0b85a97d-38bf57ce8b8mr10993299f8f.55.1737362782821; Mon, 20 Jan 2025 00:46:22 -0800 (PST) Received: from ?IPV6:2003:d8:2f22:1000:d72d:fd5f:4118:c70b? (p200300d82f221000d72dfd5f4118c70b.dip0.t-ipconnect.de. [2003:d8:2f22:1000:d72d:fd5f:4118:c70b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf3275901sm9826580f8f.61.2025.01.20.00.46.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2025 00:46:21 -0800 (PST) Message-ID: <80984553-a2b9-46b4-acdc-f7abba3c755f@redhat.com> Date: Mon, 20 Jan 2025 09:46:20 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] mm: memory-failure: update ttu flag inside unmap_poisoned_folio From: David Hildenbrand To: Miaohe Lin , Wupeng Ma Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, osalvador@suse.de, nao.horiguchi@gmail.com, mhocko@suse.com References: <20250116061657.227027-1-mawupeng1@huawei.com> <20250116061657.227027-2-mawupeng1@huawei.com> <21674fcc-bd5d-3e32-6e45-f0a16ab93202@huawei.com> <34ccd133-7623-4cd8-aad7-08526a97c472@redhat.com> Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <34ccd133-7623-4cd8-aad7-08526a97c472@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20.01.25 08:49, David Hildenbrand wrote: > >>> if (folio_test_hugetlb(folio) && !folio_test_anon(folio)) { >>> struct address_space *mapping; >>> >>> @@ -1572,7 +1598,7 @@ void unmap_poisoned_folio(struct folio *folio, enum ttu_flags ttu) >>> if (!mapping) { >>> pr_info("%#lx: could not lock mapping for mapped hugetlb folio\n", >>> folio_pfn(folio)); >>> - return; >>> + return -EBUSY; >>> } >>> >>> try_to_unmap(folio, ttu|TTU_RMAP_LOCKED); >>> @@ -1580,6 +1606,8 @@ void unmap_poisoned_folio(struct folio *folio, enum ttu_flags ttu) >>> } else { >>> try_to_unmap(folio, ttu); >>> } >>> + >>> + return folio_mapped(folio) ? -EBUSY : 0; >> >> Do we really need this return value? It's unused in do_migrate_range(). > > I suggested it, because the folio_mapped() is nowadays extremely cheap. > It cleans up hwpoison_user_mappings() quite nicely. I'm also wondering, if in do_migrate_range(), we want to pr_warn_ratelimit() in case still mapped after the call. IIUC, we don't really expect this to happen with SYNC set. -- Cheers, David / dhildenb