From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FC632DCF5C for ; Mon, 25 Aug 2025 10:53:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.118.77.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756119225; cv=none; b=aiXCnE7LwO4tRb550ZBBMibqq1Ze1crLec4STXzOQtsJFUqLWLTutRMcjA8rlRyH2AUiNuZoE+8Q1BLOaQaWpMEDPdaFSfkbMiwqUDYfVjUM7vILZcsbPjFI0E0pPNvZO5/j6qgZ3dalIZRZS0vdn5Pp0zEtm0lRlcMPbjdtcko= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756119225; c=relaxed/simple; bh=QqJu6QjgWVorILPoRw/+xHaerh+Bd01I8TBlH3G1MSY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:In-Reply-To: Content-Type:References; b=RJ1A39YwLOJ11Xnajt5DmJzjpaNW2kIXY11v3Tnf7ZoPIEtV4w30c3vKa4iz+SGZcB3PP2keu2IoNW/qzEtjG1Ojh9pnVLQrLLc8S3XifFUrEkqiquwIMfi/MTCbkS6Zh65Hmc0o9ijeiE/FJZibs2aa8J/BEui3ikUVYpbcXZs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=O7Cv3ims; arc=none smtp.client-ip=210.118.77.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="O7Cv3ims" Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20250825105340euoutp0199e60c2c55a22f301335d100d7877d9a~e-SBgneW60148801488euoutp01U for ; Mon, 25 Aug 2025 10:53:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20250825105340euoutp0199e60c2c55a22f301335d100d7877d9a~e-SBgneW60148801488euoutp01U DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1756119220; bh=/fa4+ZI2ynYvAnmTSBhg899GLSJbeJtzYjuSjpeEGlo=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=O7Cv3imsFNC7IeAXaIsQOTVSs76RWqKfhuY1jXd2FZM3Ej/vljQpDs3xEZkUN5oVS yD3dDR5BV5Iy+WZgQeEsmHuWRu5jXr5enJzwDjpRONP0YLo+IUG8+2kMY+tteupH4e 6arTUTVUhfF3zVlfow0G8gUAI3YCMMvTsmHj+HwI= Received: from eusmtip1.samsung.com (unknown [203.254.199.221]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20250825105339eucas1p13cf980f9b7f4ba4f465f5953b97f149c~e-SA9vcu40800108001eucas1p1m; Mon, 25 Aug 2025 10:53:39 +0000 (GMT) Received: from [106.210.134.192] (unknown [106.210.134.192]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20250825105337eusmtip19068233323fe8c45892597caf271a2e6~e-R-X77KD1201812018eusmtip19; Mon, 25 Aug 2025 10:53:37 +0000 (GMT) Message-ID: <809848c9-2ffa-4743-adda-b8b714b404de@samsung.com> Date: Mon, 25 Aug 2025 12:53:37 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Betterbird (Windows) Subject: Re: [PATCH net-next v3] net: ethernet: stmmac: dwmac-rk: Make the clk_phy could be used for external phy To: Chaoyi Chen , Chaoyi Chen , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , "Russell King (Oracle)" , Jonas Karlman , David Wu Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Content-Language: en-US From: Marek Szyprowski In-Reply-To: Content-Transfer-Encoding: 8bit X-CMS-MailID: 20250825105339eucas1p13cf980f9b7f4ba4f465f5953b97f149c X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20250825072312eucas1p2d4751199c0ea069c7938218be60e5e93 X-EPHeader: CA X-CMS-RootMailID: 20250825072312eucas1p2d4751199c0ea069c7938218be60e5e93 References: <20250815023515.114-1-kernel@airkyi.com> On 25.08.2025 11:57, Chaoyi Chen wrote: > On 8/25/2025 3:23 PM, Marek Szyprowski wrote: >> On 15.08.2025 04:35, Chaoyi Chen wrote: >>> From: Chaoyi Chen >>> >>> For external phy, clk_phy should be optional, and some external phy >>> need the clock input from clk_phy. This patch adds support for setting >>> clk_phy for external phy. >>> >>> Signed-off-by: David Wu >>> Signed-off-by: Chaoyi Chen >>> --- >>> >>> Changes in v3: >>> - Link to V2: >>> https://lore.kernel.org/netdev/20250812012127.197-1-kernel@airkyi.com/ >>> - Rebase to net-next/main >>> >>> Changes in v2: >>> - Link to V1: >>> https://lore.kernel.org/netdev/20250806011405.115-1-kernel@airkyi.com/ >>> - Remove get clock frequency from DT prop >>> >>>    drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 11 +++++++---- >>>    1 file changed, 7 insertions(+), 4 deletions(-) >>> >>> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c >>> b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c >>> index ac8288301994..5d921e62c2f5 100644 >>> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c >>> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c >>> @@ -1412,12 +1412,15 @@ static int rk_gmac_clk_init(struct >>> plat_stmmacenet_data *plat) >>>            clk_set_rate(plat->stmmac_clk, 50000000); >>>        } >>>    -    if (plat->phy_node && bsp_priv->integrated_phy) { >>> +    if (plat->phy_node) { >>>            bsp_priv->clk_phy = of_clk_get(plat->phy_node, 0); >>>            ret = PTR_ERR_OR_ZERO(bsp_priv->clk_phy); >>> -        if (ret) >>> -            return dev_err_probe(dev, ret, "Cannot get PHY clock\n"); >>> -        clk_set_rate(bsp_priv->clk_phy, 50000000); >>> +        /* If it is not integrated_phy, clk_phy is optional */ >>> +        if (bsp_priv->integrated_phy) { >>> +            if (ret) >>> +                return dev_err_probe(dev, ret, "Cannot get PHY >>> clock\n"); >>> +            clk_set_rate(bsp_priv->clk_phy, 50000000); >>> +        } > > I think  we should set bsp_priv->clk_phy to NULL here if we failed to > get the clock. > > Could you try this on your board? Thank you. Right, the following change also fixes this issue: diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c index 9fc41207cc45..2d19d48be01f 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c @@ -1415,6 +1415,8 @@ static int rk_gmac_clk_init(struct plat_stmmacenet_data *plat)         if (plat->phy_node) {                 bsp_priv->clk_phy = of_clk_get(plat->phy_node, 0);                 ret = PTR_ERR_OR_ZERO(bsp_priv->clk_phy); +               if (ret) +                       bsp_priv->clk_phy = NULL;                 /* If it is not integrated_phy, clk_phy is optional */                 if (bsp_priv->integrated_phy) {                         if (ret) > ... Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland