From: Stewart Smith <stewartsmith@mac.com>
To: viro@parcelfarce.linux.theplanet.co.uk
Cc: William Lee Irwin III <wli@holomorphy.com>,
linux-kernel@vger.kernel.org, trivial@rustcorp.com.au
Subject: Re: buffer_head.b_bsize type
Date: Fri, 30 May 2003 00:19:05 +1000 [thread overview]
Message-ID: <80FB28EB-91E0-11D7-9488-00039346F142@mac.com> (raw)
In-Reply-To: <20030529111517.GP14138@parcelfarce.linux.theplanet.co.uk>
On Thursday, May 29, 2003, at 09:15 PM,
viro@parcelfarce.linux.theplanet.co.uk wrote:
>> Could we go the other way and make all users of b_size use unsigned?
>
> Who the hell cares? Size of buffer does not exceed the page size.
> Unless you can show a platform with 2Gb pages...
I would argue the same that the size of a buffer should never be able
to be negative and the structure says this but the rest of the code
does not. (Theoretically) if a negative size was asked for, then we'd
actually try to allocate a large amount of memory for the buffer,
possibly causing badness somewhere along the line.
Any maybe we shouldn't make it too hard for archs with 2GB pages :)
It'll probably happen in 20 years. :)
------------------------------
Stewart Smith
stewartsmith@mac.com
Ph: +61 4 3884 4332
ICQ: 6734154
http://www.flamingspork.com/ http://www.linux.org.au
prev parent reply other threads:[~2003-05-29 14:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-29 10:29 Stewart Smith
2003-05-29 10:35 ` William Lee Irwin III
2003-05-29 11:15 ` viro
2003-05-29 11:28 ` William Lee Irwin III
2003-05-30 14:24 ` Andries Brouwer
2003-05-30 14:43 ` Andries Brouwer
2003-05-31 2:20 ` William Lee Irwin III
2003-05-29 14:19 ` Stewart Smith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80FB28EB-91E0-11D7-9488-00039346F142@mac.com \
--to=stewartsmith@mac.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@rustcorp.com.au \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®