From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 996063E2748 for ; Tue, 5 May 2026 07:54:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777967701; cv=none; b=fCU20fJhhLz2XZmjgHIYdlkZMui5qUGRwL8s3aL2yRLZc9hwMex3Y8Pk1rGMDvJ6wQzduMX16Bu4mR2o8iJYc63cFibNF30PQk5GGlQqhtcmcPhGRA6g0Njh79I8Ka+EzRwXT/4+kAz/FLIxtVmXbGYAWVkoEXWX62eo0CqL+tM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777967701; c=relaxed/simple; bh=1+aO1jsqt4+7D7eVQn3EaDYl7VdHvbbO7pn/PcTHylE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CjhfsKsPadEyB70t3yQGpTaO4D37OaF6KZhDSCMhFAvKWWl8YPHPx7QBrMwJsewKO+nM0FAQElb79HKQRhuJw9j/IExXhOJSnafk5IbtNJylUekfcUS51d25Qog8OVXQgVqhRezYSVRUbUblVNB98a6ohA0bObZiKqUngS9GMKI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=blackwall.org; spf=none smtp.mailfrom=blackwall.org; dkim=pass (2048-bit key) header.d=blackwall.org header.i=@blackwall.org header.b=SFRfJg7c; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=blackwall.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=blackwall.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=blackwall.org header.i=@blackwall.org header.b="SFRfJg7c" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4891e5b9c1fso46828145e9.2 for ; Tue, 05 May 2026 00:54:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blackwall.org; s=google; t=1777967697; x=1778572497; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9GZJftakxhfNgeo2AWQ3HNwbl0xuJXtG3r/LfqS/vsU=; b=SFRfJg7cDwL6ILqezIGvWWELPkl/+facN02WL0YURQEF/tUZf/99AaNm/qnruInjUV A1sFj/H2hbvqwnlSPFJiWHB/yNL/KTLeHvoefd05pSN6znlY9BTWQ7TjshgAHsbk2kbe zCVt9KAkQAQa8eEtXN8z9zzTUi4KN/FKu4zW2Ozh8RL/pMl/rTDzDod/EkeDg3qtDVAD k4BQRITyaI6oo/dByynASxlwcp/ewxsLt6k9n6bum7Kzn975QpF5INu2hR8RqLYm3Fwc Ub0dsix6fv8ow3C6UDKKm+HmJkzu2VB69lh3+XZAN0PipHo7hm2or5r6jEZOzviMOatF /11w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777967697; x=1778572497; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9GZJftakxhfNgeo2AWQ3HNwbl0xuJXtG3r/LfqS/vsU=; b=k9PAxNE6ija973JZQtjOiSdutrMK/BMzifZcIrKfyAAAOUtUmDVSMQuyIgT4GAbgmz oSkAo7XzzJgZNI6IVR9ikrBgDBu7oK/Rxu3wPysCYx09kbDisF0os7PJeWmDY5o9vPAp JqfWL0nkRLaeDrNsmDpYK6Od9jgqnxw+0GCmpTbMDWS7XJs9ZiAuqvSldTi6khN6rgY8 3ES3XCC6EA12mTbI1l09sad8eChcat48dCIvUkJM/n8243ouqZBD+DqQxnYX5jRlWFx1 moqqWuz6eOLzR5ww5xq1woZe/dZ0hmUlE+s0QEQzGahHY5AxK3xhaRR2knadXloZsd3E fthQ== X-Forwarded-Encrypted: i=1; AFNElJ+i9F82jj/LvDOpxxfWSGwpQMMqoV8izEdV3oxyBOReijIy/xkRegXMP5eUP4tggqpLLtFYaQcVaxT47Pg=@vger.kernel.org X-Gm-Message-State: AOJu0YwNQXEsoGgL+eJ6ldXfTX9TBuYiEPpgT2xXpsf5oE6sPnmfT9Dr rKdjsKd7FZuppKlNplaTHSIEDDt+XY6o5s6bKE7dFqrGpmaWD3gbjBPoYwvDNkztfiU= X-Gm-Gg: AeBDieso2nwuW5/uGXp+fp8wyN7sOA4w6OFEDr8dik85JyOMPe5mGlu+WycHUx13j0A 8Lxz/GLIUTRQ3Gy59Qce3X3MzBT48WpIyVtuye0oP8Aeg37eq+ZyiGW4a8TVxN0MylWAccTS7A7 0IGuM09dixen7HX7xAj/scjpBxcu9vBcVX+EWGXYq1n7CNVDaGIKhEZ2OsZHiywI1UlI0HXkQa4 wUXB2Mg1YX5o3W9hFZ9qC5QrLZGbj3XKVKR6zPiLN87cK6pl+zutfjCswoeEDYuh79ypRQFqqFl TKsvBrnFCZoyd2z8rAADnH/OG45M1m/zfm27a9LgDS86BJ2XL0wwT5G39WKFYYmmRyGdipyH1AT Lv8yDKfiJi8aEVZbWGjALh14j6nTpOWa4i02ErIAMFvwLhj5d1CC5PGk0NmkqbT/q9UEypIprE8 yBughZyYFUBHPJK23wDopzk6XD+Hlsyk+vKAirUWUhjEJZK9Bj9xyTpVuNJbyzZ6tt X-Received: by 2002:a05:600c:811a:b0:48a:93f8:dd02 with SMTP id 5b1f17b1804b1-48d18bdc477mr28515045e9.14.1777967696952; Tue, 05 May 2026 00:54:56 -0700 (PDT) Received: from [192.168.0.161] (78-154-15-182.ip.btc-net.bg. [78.154.15.182]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a8eb3427fsm544750905e9.0.2026.05.05.00.54.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 May 2026 00:54:56 -0700 (PDT) Message-ID: <80a0822d-7f31-4191-b434-8c84b37b4900@blackwall.org> Date: Tue, 5 May 2026 10:54:55 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2] net: bridge: replace simple_strtoul with kstrtoul Content-Language: en-US, bg To: Aadarsh Chandra , idosch@nvidia.com Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, bridge@lists.linux.dev, linux-kernel@vger.kernel.org References: <20260505074515.636244-1-aadarsh.official.xz@gmail.com> From: Nikolay Aleksandrov In-Reply-To: <20260505074515.636244-1-aadarsh.official.xz@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05/05/2026 10:45, Aadarsh Chandra wrote: > The simple_strtoul() function is deprecated. It does not handle > errors or overflows correctly. Replace it with kstrtoul() in > brport_store() to ensure that invalid user input is caught and > returned as an error. > > v2: target net-next and simplify by reusing the ret variable as > suggested by Nikolay Aleksandrov. > Nice that you've given us the changes, but it should be below... > Signed-off-by: Aadarsh Chandra > --- ... here, so it's not included in the commit message. > net/bridge/br_sysfs_if.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/net/bridge/br_sysfs_if.c b/net/bridge/br_sysfs_if.c > index 1f57c36a7fc0..cdecc7d1260c 100644 > --- a/net/bridge/br_sysfs_if.c > +++ b/net/bridge/br_sysfs_if.c > @@ -318,7 +318,6 @@ static ssize_t brport_store(struct kobject *kobj, > struct net_bridge_port *p = kobj_to_brport(kobj); > ssize_t ret = -EINVAL; > unsigned long val; > - char *endp; > > if (!ns_capable(dev_net(p->dev)->user_ns, CAP_NET_ADMIN)) > return -EPERM; > @@ -339,8 +338,8 @@ static ssize_t brport_store(struct kobject *kobj, > spin_unlock_bh(&p->br->lock); > kfree(buf_copy); > } else if (brport_attr->store) { > - val = simple_strtoul(buf, &endp, 0); > - if (endp == buf) > + ret = kstrtoul(buf, 0, &val); > + if (ret) > goto out_unlock; > spin_lock_bh(&p->br->lock); > ret = brport_attr->store(p, val); You should wait 24 hours before posting a new version. The patch looks good to me, if there's a need for v3 please add my: Acked-by: Nikolay Aleksandrov Cheers, Nik