mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: Yury Norov <yury.norov@gmail.com>
Cc: Borislav Petkov <bp@alien8.de>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	syzbot <syzbot+d0fd2bf0dd6da72496dd@syzkaller.appspotmail.com>,
	syzkaller-bugs@googlegroups.com,
	Andrew Jones <ajones@ventanamicro.com>,
	netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Menglong Dong <imagedong@tencent.com>,
	Kuniyuki Iwashima <kuniyu@amazon.com>,
	Petr Machata <petrm@nvidia.com>,
	Guo Ren <guoren@linux.alibaba.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk,
	caraitto@google.com, willemb@google.com, jonolson@google.com,
	amritha.nambiar@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [syzbot] WARNING in c_start
Date: Sun, 16 Oct 2022 13:10:18 +0900	[thread overview]
Message-ID: <80a12dd3-dae4-ccc7-e277-b2fd2cba78e2@I-love.SAKURA.ne.jp> (raw)
In-Reply-To: <Y0tafD7qI2x5xzTc@yury-laptop>

On 2022/10/16 10:12, Yury Norov wrote:
> On Sun, Oct 16, 2022 at 09:24:57AM +0900, Tetsuo Handa wrote:
>> I'm asking you not to use BUG_ON()/WARN_ON() etc. which breaks syzkaller.
> 
> It's not me who added WARN_ON() in the cpumask_check(). You're asking
> a wrong person. 

Because you broke the kernel testing. It was obvious that passing "cpu + 1"
instead of "cpu" will trivially hit cpu == nr_cpumask_bits condition.
If your patch were reviewed and tested, we would not have done this discussion.

> 
> What for do we have WARN_ON(), if we can't use it?

WARN_ON() could be used which should not happen.
But cpu == nr_cpumask_bits condition shall happen in your patch.

RCs are not for fixing bugs that causes boot failures. Such bugs
should have been tested and fixed before patches are sent to linux.git .

> 
>> Just printing messages (without "BUG:"/"WARNING:" string which also breaks
>> syzkaller) like below diff is sufficient for people to realize that they're
>> doing something wrong.
>>
>> Again, please do revert "cpumask: fix checking valid cpu range" immediately.
> 
> The revert is already in Jakub's batch for -rc2, AFAIK.

OK.


  reply	other threads:[~2022-10-16  4:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-14 21:16 syzbot
2022-10-14 21:24 ` Borislav Petkov
     [not found]   ` <2eaf1386-8ab0-bd65-acee-e29f1c5a6623@I-love.SAKURA.ne.jp>
     [not found]     ` <Y0qfLyhSoTodAdxu@zn.tnic>
2022-10-15 20:44       ` Yury Norov
2022-10-16  0:24         ` Tetsuo Handa
2022-10-16  0:28           ` Randy Dunlap
2022-10-16  0:34             ` Tetsuo Handa
2022-10-16  1:12           ` Yury Norov
2022-10-16  4:10             ` Tetsuo Handa [this message]
2022-10-16 17:52             ` Linus Torvalds
2022-10-17  2:54               ` Tetsuo Handa
2022-10-17 21:26                 ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80a12dd3-dae4-ccc7-e277-b2fd2cba78e2@I-love.SAKURA.ne.jp \
    --to=penguin-kernel@i-love.sakura.ne.jp \
    --cc=agordeev@linux.ibm.com \
    --cc=ajones@ventanamicro.com \
    --cc=amritha.nambiar@intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bigeasy@linutronix.de \
    --cc=bp@alien8.de \
    --cc=caraitto@google.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=guoren@linux.alibaba.com \
    --cc=imagedong@tencent.com \
    --cc=jonolson@google.com \
    --cc=kuba@kernel.org \
    --cc=kuniyu@amazon.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    --cc=syzbot+d0fd2bf0dd6da72496dd@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=torvalds@linux-foundation.org \
    --cc=willemb@google.com \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®