From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752165AbbBRLa6 (ORCPT ); Wed, 18 Feb 2015 06:30:58 -0500 Received: from cmexedge2.emulex.com ([138.239.224.100]:22113 "EHLO CMEXEDGE2.ext.emulex.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751940AbbBRLa5 convert rfc822-to-8bit (ORCPT ); Wed, 18 Feb 2015 06:30:57 -0500 From: Mitesh Ahuja To: kbuild test robot CC: "kbuild-all@01.org" , Roland Dreier , Devesh Sharma , "Selvin Xavier" , Sean Hefty , "Hal Rosenstock" , Duan Jiong , "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH next] RDMA/ocrdma: ocrdma_sysfs_rcv_pkts() can be static Thread-Topic: [PATCH next] RDMA/ocrdma: ocrdma_sysfs_rcv_pkts() can be static Thread-Index: AQHQSy2HkN1u2cJ3tkesaFbkoBaMPZz2RI7A Date: Wed, 18 Feb 2015 11:30:22 +0000 Message-ID: <80a631cc-5b3b-4059-bea6-6656c2d8669a@CMEXHTCAS2.ad.emulex.com> References: <201502181128.AqJYFmKG%fengguang.wu@intel.com> <20150218034553.GA38068@snb> In-Reply-To: <20150218034553.GA38068@snb> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.226.193.23] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Acked-by: Mitesh Ahuja. -----Original Message----- From: kbuild test robot [mailto:fengguang.wu@intel.com] Sent: Wednesday, February 18, 2015 9:16 AM To: Mitesh Ahuja Cc: kbuild-all@01.org; Roland Dreier; Devesh Sharma; Selvin Xavier; Sean Hefty; Hal Rosenstock; Duan Jiong; linux-rdma@vger.kernel.org; linux-kernel@vger.kernel.org Subject: [PATCH next] RDMA/ocrdma: ocrdma_sysfs_rcv_pkts() can be static drivers/infiniband/hw/ocrdma/ocrdma_stats.c:253:5: sparse: symbol 'ocrdma_sysfs_rcv_pkts' was not declared. Should it be static? drivers/infiniband/hw/ocrdma/ocrdma_stats.c:264:5: sparse: symbol 'ocrdma_sysfs_rcv_data' was not declared. Should it be static? drivers/infiniband/hw/ocrdma/ocrdma_stats.c:317:5: sparse: symbol 'ocrdma_sysfs_xmit_pkts' was not declared. Should it be static? drivers/infiniband/hw/ocrdma/ocrdma_stats.c:332:5: sparse: symbol 'ocrdma_sysfs_xmit_data' was not declared. Should it be static? Signed-off-by: Fengguang Wu --- ocrdma_stats.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c index 9d1701f..614d1a8 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c +++ b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c @@ -250,7 +250,7 @@ static char *ocrdma_rx_stats(struct ocrdma_dev *dev) return stats; } -u64 ocrdma_sysfs_rcv_pkts(struct ocrdma_dev *dev) +static u64 ocrdma_sysfs_rcv_pkts(struct ocrdma_dev *dev) { struct ocrdma_rdma_stats_resp *rdma_stats = (struct ocrdma_rdma_stats_resp *)dev->stats_mem.va; @@ -261,7 +261,7 @@ u64 ocrdma_sysfs_rcv_pkts(struct ocrdma_dev *dev) + (u64)rx_stats->roce_frame_payload_len_drops; } -u64 ocrdma_sysfs_rcv_data(struct ocrdma_dev *dev) +static u64 ocrdma_sysfs_rcv_data(struct ocrdma_dev *dev) { struct ocrdma_rdma_stats_resp *rdma_stats = (struct ocrdma_rdma_stats_resp *)dev->stats_mem.va; @@ -314,7 +314,7 @@ static char *ocrdma_tx_stats(struct ocrdma_dev *dev) return stats; } -u64 ocrdma_sysfs_xmit_pkts(struct ocrdma_dev *dev) +static u64 ocrdma_sysfs_xmit_pkts(struct ocrdma_dev *dev) { struct ocrdma_rdma_stats_resp *rdma_stats = (struct ocrdma_rdma_stats_resp *)dev->stats_mem.va; @@ -329,7 +329,7 @@ u64 ocrdma_sysfs_xmit_pkts(struct ocrdma_dev *dev) convert_to_64bit(tx_stats->ack_pkts_lo, tx_stats->ack_pkts_hi)); } -u64 ocrdma_sysfs_xmit_data(struct ocrdma_dev *dev) +static u64 ocrdma_sysfs_xmit_data(struct ocrdma_dev *dev) { struct ocrdma_rdma_stats_resp *rdma_stats = (struct ocrdma_rdma_stats_resp *)dev->stats_mem.va;