From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Colin King <colin.king@canonical.com>,
"David S . Miller" <davem@davemloft.net>,
linux-ide@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ide: hpt366: fix incorrect mask when checking at cmd_high_time
Date: Tue, 12 Jul 2016 14:09:51 +0300 [thread overview]
Message-ID: <80ace01e-b03e-39f8-a6fe-ad2f61079731@cogentembedded.com> (raw)
In-Reply-To: <034d8edb-439e-eafe-0743-4b69bf50b49e@cogentembedded.com>
On 7/12/2016 2:04 PM, Sergei Shtylyov wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> According to the HPT366 data sheet, PCI config space dword 0x40-0x43
>> bits 11:8 specify the primary drive cmd_high_time, however,
>> currently just 3 bits of the 4 are being used because the mask
>> is 0x07 and not 0x0f. Fix the mask, allowing for the 40MHz clock
>> to be detected.
>>
>> Also add in missing space between switch and parenthesis to clean
>> up a checkpatch warning.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
BTW, drivers/ata/pata_hpt366.c has the same bug...
MBR, Sergei
next prev parent reply other threads:[~2016-07-12 11:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 10:59 Colin King
2016-07-12 11:04 ` Sergei Shtylyov
2016-07-12 11:09 ` Sergei Shtylyov [this message]
2016-07-12 11:10 ` Colin Ian King
2016-07-12 11:16 ` Sergei Shtylyov
2016-07-26 22:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80ace01e-b03e-39f8-a6fe-ad2f61079731@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®