From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752041AbdI0VP6 (ORCPT ); Wed, 27 Sep 2017 17:15:58 -0400 Received: from esa5.dell-outbound.iphmx.com ([68.232.153.95]:30125 "EHLO esa5.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751801AbdI0VP4 (ORCPT ); Wed, 27 Sep 2017 17:15:56 -0400 From: X-LoopCount0: from 10.166.132.187 X-IronPort-AV: E=Sophos;i="5.42,446,1500958800"; d="scan'208";a="1158111275" X-DLP: DLP_GlobalPCIDSS To: , CC: , , , Subject: RE: [PATCH 04/12] platform/x86: dell-smbios: Switch to a WMI-ACPI interface Thread-Topic: [PATCH 04/12] platform/x86: dell-smbios: Switch to a WMI-ACPI interface Thread-Index: AQHTN8mCFbNXx7swGkuM2tkKZyREFaLJOxwQ Date: Wed, 27 Sep 2017 21:15:51 +0000 Message-ID: <80aff96a283c457b90f948ce9c7872b3@ausx13mpc120.AMER.DELL.COM> References: <4da87eb0d9722ed906615409586a8b4d7becd65c.1505999739.git.mario.limonciello@dell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.18.86] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v8RLG36X020540 > -----Original Message----- > From: Andy Lutomirski [mailto:luto@kernel.org] > Sent: Wednesday, September 27, 2017 3:48 PM > To: Limonciello, Mario ; dvhart@infradead.org > Cc: LKML ; platform-driver-x86@vger.kernel.org; > quasisec@google.com; pali.rohar@gmail.com > Subject: Re: [PATCH 04/12] platform/x86: dell-smbios: Switch to a WMI-ACPI > interface > > On 09/21/2017 06:57 AM, Mario Limonciello wrote: > > The driver currently uses an SMI interface which grants direct access > > to physical memory to the platform via a pointer. > > > > Changing this to operate over WMI-ACPI will use an ACPI OperationRegion > > for a buffer of data storage when platform calls are performed. > > > > This is a safer approach to use in kernel drivers as the platform will > > only have access to that OperationRegion. > > > > As a result, this change removes the dependency on this driver on the > > dcdbas kernel module. > > > > > + status = wmi_evaluate_method(DELL_WMI_SMBIOS_GUID, > > + 0, 1, &input, &output); > > It might be nice to add a wmidev_method_evaluate(struct wmi_device > *wdev, ...) function to better aligh with the new world order. The only > reason I didn't do it is that I didn't convert any drivers that wanted it. Great idea. I'll apply that for my next patch revision. I'm not about to convert all the existing drivers, but once all existing drivers conceptualize using the bus, storing a wmi_device pointer internally,and using this the old wmi_evaluate_method can be dropped too.