From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755756AbYIKNrH (ORCPT ); Thu, 11 Sep 2008 09:47:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756097AbYIKNqi (ORCPT ); Thu, 11 Sep 2008 09:46:38 -0400 Received: from mail-gx0-f16.google.com ([209.85.217.16]:46295 "EHLO mail-gx0-f16.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756088AbYIKNqh (ORCPT ); Thu, 11 Sep 2008 09:46:37 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=D8MyUteeT3mU6WbizLeie4MOC2YWLUBi3Rl8zFbeCY229RQP8Hjk2/Jh2hT0NoceYT LL6HcT2XVXvNMa83V71ozunuqJUmXgaN5+KCQ4+SdH1IszUdHKaNgylW/a/VF3skJ+bo n/+B3pON2cUfRp8T29uCvM841j0WhlCANrnEE= Message-ID: <80b317760809110646l6e0f678v2d17d9823653d642@mail.gmail.com> Date: Thu, 11 Sep 2008 15:46:35 +0200 From: "Richard Genoud" To: "Julia Lawall" Subject: Re: [PATCH 2/5] drivers/media/common/tuners: Drop code after return or goto Cc: mchehab@infradead.org, v4l-dvb-maintainer@linuxtv.org, video4linux-list@redhat.com, vigneshbabu@gmail.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2008/9/11 Julia Lawall : > From: Julia Lawall > > The break after the return or goto serves no purpose. > > Signed-off-by: Julia Lawall Reviewed-by: Richard Genoud > --- > drivers/media/common/tuners/mxl5007t.c | 1 - > drivers/media/common/tuners/tda18271-fe.c | 1 - > drivers/media/common/tuners/tda9887.c | 1 - > drivers/media/common/tuners/tuner-simple.c | 1 - > 4 files changed, 4 deletions(-) > > diff -u -p a/drivers/media/common/tuners/tuner-simple.c b/drivers/media/common/tuners/tuner-simple.c > --- a/drivers/media/common/tuners/tuner-simple.c > +++ b/drivers/media/common/tuners/tuner-simple.c > @@ -1038,7 +1038,6 @@ struct dvb_frontend *simple_tuner_attach > case 0: > mutex_unlock(&tuner_simple_list_mutex); > return NULL; > - break; > case 1: > fe->tuner_priv = priv; > > diff -u -p a/drivers/media/common/tuners/tda18271-fe.c b/drivers/media/common/tuners/tda18271-fe.c > --- a/drivers/media/common/tuners/tda18271-fe.c > +++ b/drivers/media/common/tuners/tda18271-fe.c > @@ -1155,7 +1155,6 @@ struct dvb_frontend *tda18271_attach(str > switch (instance) { > case 0: > goto fail; > - break; > case 1: > /* new tuner instance */ > priv->gate = (cfg) ? cfg->gate : TDA18271_GATE_AUTO; > diff -u -p a/drivers/media/common/tuners/mxl5007t.c b/drivers/media/common/tuners/mxl5007t.c > --- a/drivers/media/common/tuners/mxl5007t.c > +++ b/drivers/media/common/tuners/mxl5007t.c > @@ -979,7 +979,6 @@ struct dvb_frontend *mxl5007t_attach(str > switch (instance) { > case 0: > goto fail; > - break; > case 1: > /* new tuner instance */ > state->config = cfg; > diff -u -p a/drivers/media/common/tuners/tda9887.c b/drivers/media/common/tuners/tda9887.c > --- a/drivers/media/common/tuners/tda9887.c > +++ b/drivers/media/common/tuners/tda9887.c > @@ -686,7 +686,6 @@ struct dvb_frontend *tda9887_attach(stru > case 0: > mutex_unlock(&tda9887_list_mutex); > return NULL; > - break; > case 1: > fe->analog_demod_priv = priv; > priv->mode = T_STANDBY; >