From: "Richard Genoud" <richard.genoud@gmail.com>
To: "Julia Lawall" <julia@diku.dk>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
vigneshbabu@gmail.com, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/5] fs/namespace.c: Drop code after return
Date: Thu, 11 Sep 2008 15:46:57 +0200 [thread overview]
Message-ID: <80b317760809110646m703f126cv9da4bd840a41b2a8@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0809111433270.9593@pc-004.diku.dk>
2008/9/11 Julia Lawall <julia@diku.dk>:
> From: Julia Lawall <julia@diku.dk>
>
> The extra semicolon serves no purpose.
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Reviewed-by: Richard Genoud <richard.genoud@gmail.com>
> ---
>
> fs/namespace.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/namespace.c b/fs/namespace.c
> index 6e283c9..7e6151a 100644
> --- a/fs/namespace.c
> +++ b/fs/namespace.c
> @@ -1993,7 +1993,7 @@ static struct mnt_namespace *dup_mnt_ns(struct mnt_namespace *mnt_ns,
> if (!new_ns->root) {
> up_write(&namespace_sem);
> kfree(new_ns);
> - return ERR_PTR(-ENOMEM);;
> + return ERR_PTR(-ENOMEM);
> }
> spin_lock(&vfsmount_lock);
> list_add_tail(&new_ns->list, &new_ns->root->mnt_list);
>
prev parent reply other threads:[~2008-09-11 13:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-11 12:33 Julia Lawall
2008-09-11 13:46 ` Richard Genoud [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80b317760809110646m703f126cv9da4bd840a41b2a8@mail.gmail.com \
--to=richard.genoud@gmail.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vigneshbabu@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®