Re: [RFC PATCH v5 2/3] virtio-spi: Add virtio-spi.h

[Haixu Cui <quic_haixcui@quicinc.com>]

On 6/30/2025 2:59 PM, Mukesh Kumar Savaliya wrote:
> 
> 
> On 6/20/2025 9:42 AM, Haixu Cui wrote:
>> Add virtio-spi.h header for virtio SPI.
>>
>> Signed-off-by: Haixu Cui <quic_haixcui@quicinc.com>
>> ---
>>   include/uapi/linux/virtio_spi.h | 185 ++++++++++++++++++++++++++++++++
>>   1 file changed, 185 insertions(+)
>>   create mode 100644 include/uapi/linux/virtio_spi.h

>> + * @max_cs_setup_ns: the maximum delay supported after chipselect is 
>> asserted,
> And before clock start. may also sound good, if we can write "delay 
> between CS assert to clock start"

I follow the existing comment in 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/spi/spi.h?h=v6.16-rc4#n166, 
where the cs_setup is described only in terms of the delay after CS is 
asserted, without explicitly referencing the clock signal.
To maintain consistency, I kept the comment focused on the relationship 
between the delay and the CS signal alone.