Re: [PATCH] x86/irqflags: Fix build failure

["Jürgen Groß" <jgross@suse.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1081 bytes --]

On 19.01.26 15:10, Borislav Petkov wrote:
> On Mon, Jan 19, 2026 at 02:58:45PM +0100, Jürgen Groß wrote:
>> Ah, yes. The build error happens due to the change of io.h: instead of
>> including paravirt.h only paravirt-base.h is included. Obviously several
>> sources did include io.h and irqflags.h, but no other header including
>> paravirt.h.
> 
> So your io set needs the paravirt pile from tip/x86/paravirt. So you can
> include paravirt.h in there and no need for a "fix" patch.
> 

Sigh.

paravirt.h is a big hammer.

Switching to paravirt-base.h is part of the goal to reduce include hell
with paravirt.

Why do you insist on keeping irqflags.h inconsistent by not defining
some prototypes if CONFIG_PARAVIRT is set, but not CONFIG_PARAVIRT_XXL.

Commit 22cc5ca5de52 was just missing the part of my patch. It was wrong.
Should have moved the "#include <asm/paravirt.h>" from the
CONFIG_PARAVIRT_XXL to the CONFIG_PARAVIRT umbrella, just like my
patch.

Or do you really think everyone including irqflags.h should include
io.h, too?


Juergen

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]