From: Paul Moore <paul@paul-moore.com>
To: Khadija Kamran <kamrankhadijadj@gmail.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org,
Stephen Smalley <stephen.smalley.work@gmail.com>,
Eric Paris <eparis@parisplace.org>,
selinux@vger.kernel.org, ztarkhani@microsoft.com,
Alison Schofield <alison.schofield@intel.com>
Subject: Re: [PATCH] lsm: constify the 'file' parameter in security_binder_transfer_file()
Date: Tue, 15 Aug 2023 16:04:33 -0400 [thread overview]
Message-ID: <80c3c2b488a603da62a0fd15201dec0b.paul@paul-moore.com> (raw)
In-Reply-To: <ZNelvBCFG7wZt24g@gmail.com>
On Aug 12, 2023 Khadija Kamran <kamrankhadijadj@gmail.com> wrote:
>
> SELinux registers the implementation for the "binder_transfer_file"
> hook. Looking at the function implementation we observe that the
> parameter "file" is not changing.
>
> Mark the "file" parameter of LSM hook security_binder_transfer_file() as
> "const" since it will not be changing in the LSM hook.
>
> Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
> ---
> include/linux/lsm_hook_defs.h | 2 +-
> include/linux/security.h | 4 ++--
> security/security.c | 2 +-
> security/selinux/hooks.c | 8 ++++----
> 4 files changed, 8 insertions(+), 8 deletions(-)
Looks good to me, merged into lsm/next, thanks!
--
paul-moore.com
prev parent reply other threads:[~2023-08-15 20:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-12 15:31 Khadija Kamran
2023-08-15 20:04 ` Paul Moore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80c3c2b488a603da62a0fd15201dec0b.paul@paul-moore.com \
--to=paul@paul-moore.com \
--cc=alison.schofield@intel.com \
--cc=eparis@parisplace.org \
--cc=jmorris@namei.org \
--cc=kamrankhadijadj@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=selinux@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=stephen.smalley.work@gmail.com \
--cc=ztarkhani@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®