From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03988C54EE9 for ; Tue, 27 Sep 2022 08:45:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231358AbiI0IpC (ORCPT ); Tue, 27 Sep 2022 04:45:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231278AbiI0Io6 (ORCPT ); Tue, 27 Sep 2022 04:44:58 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 614F113F19; Tue, 27 Sep 2022 01:44:56 -0700 (PDT) X-UUID: 3cff573d63a5463b8575cdc626798079-20220927 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=CSa/p/zpHyX4lGO/pfARnTvy0LVC/OySswcI+oOiq+w=; b=s5eDKfDFOiBcz8vA8P9T0uNviM4VbzUpvt2v38wE5SNXdSiItPlbJXZTkSfxbUX6dtygRXg60AiRHwb7He+Wvt+bxE54gjfk1/yR0V8205ExrPcc/xpbTvARfFPana15l6q256YcPPNxvTkqUFrPFYkcgfSjAAu+ehMrF2b0NzY=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.11,REQID:4f85f88e-29be-4e3c-9057-391323366e14,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:39a5ff1,CLOUDID:688237a3-dc04-435c-b19b-71e131a5fc35,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0 X-UUID: 3cff573d63a5463b8575cdc626798079-20220927 Received: from mtkmbs10n2.mediatek.inc [(172.21.101.183)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1257761030; Tue, 27 Sep 2022 16:44:49 +0800 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Tue, 27 Sep 2022 16:44:48 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Tue, 27 Sep 2022 16:44:47 +0800 Message-ID: <80c59c9462955037981a1eab6409ba69fc9b7c34.camel@mediatek.com> Subject: Re: [PATCH v5 4/4] net: stmmac: Update the name of property 'clk_csr' From: Jianguo Zhang To: Krzysztof Kozlowski , "AngeloGioacchino Del Regno" , "David S . Miller" , Rob Herring , "Krzysztof Kozlowski" CC: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , "Matthias Brugger" , Biao Huang , , , , , , Date: Tue, 27 Sep 2022 16:44:46 +0800 In-Reply-To: <4f205f0d-420d-8f51-ad26-0c2475c0decd@linaro.org> References: <20220923052828.16581-1-jianguo.zhang@mediatek.com> <20220923052828.16581-5-jianguo.zhang@mediatek.com> <4f205f0d-420d-8f51-ad26-0c2475c0decd@linaro.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Krzysztof, Thanks for your comment. On Fri, 2022-09-23 at 20:15 +0200, Krzysztof Kozlowski wrote: > On 23/09/2022 20:14, Krzysztof Kozlowski wrote: > > > This is going to break MT2712e on old devicetrees. > > > > > > The right way of doing that is to check the return value of > > > of_property_read_u32() > > > for "snps,clk-csr": if the property is not found, fall back to > > > the old "clk_csr". > > > > I must admit - I don't care. That's the effect when submitter > > bypasses > > DT bindings review (81311c03ab4d ("net: ethernet: stmmac: add > > management > > of clk_csr property")). > > > > If anyone wants ABI, please document the properties. > > > > If out-of-tree users complain, please upstream your DTS or do not > > use > > undocumented features... > > > > OTOH, as Angelo pointed out, handling old and new properties is quite > easy to achieve, so... :) > So, the conclusion is as following: 1. add new property 'snps,clk-csr' and document it in binding file. 2. parse new property 'snps,clk-csr' firstly, if failed, fall back to old property 'clk_csr' in driver. Is my understanding correct? > Best regards, > Krzysztof > BRS Jianguo