From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752944AbdICUfT (ORCPT ); Sun, 3 Sep 2017 16:35:19 -0400 Received: from mout.web.de ([212.227.15.4]:58898 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751649AbdICUfR (ORCPT ); Sun, 3 Sep 2017 16:35:17 -0400 Subject: [PATCH 5/7] [media] Hexium Orion: Delete an error message for a failed memory allocation in hexium_probe() From: SF Markus Elfring To: linux-media@vger.kernel.org, Hans Verkuil , Mauro Carvalho Chehab , Sakari Ailus Cc: LKML , kernel-janitors@vger.kernel.org References: <170abf7f-3b62-a37c-966a-8b574acae230@users.sourceforge.net> Message-ID: <80c8a86a-5b26-0c40-5d71-730870958556@users.sourceforge.net> Date: Sun, 3 Sep 2017 22:35:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <170abf7f-3b62-a37c-966a-8b574acae230@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:EpY0t4ALIaNzudtvvbGMMu5KVSwJF++BNYAPEOTloFXqzP9MBuZ VL4Dpyal2bg60918NHQyvWk92SD+NkV4XOctJ/WrELtVYuVpPcJjFKuneAT6yUuUlg/1aZ9 38vfls19RoXmQFVJUoFp1+FuH1J3W2QADjvO9yxGNgj3PwVwCyqD4NRBTd3TTPyWufRHjDM DfcvbWDgmf2HFm4EihIAg== X-UI-Out-Filterresults: notjunk:1;V01:K0:D1wcg3GFkL8=:i8IQ5KnpOVWx37iFVQMMkO WKuP+1/+VYYhHN8ogGLkq1I8t3Z0xILJUYorQ6x9lFxUTEnKQ2IXLCnQpLvpC5qHcOrSaxvxP EY6cKcBKsUgIcdHVpZG17BlKRQa70ZFxT6G29ZKj986iieP97o2+pbMJO/xA5ZmiIDA3o6Vjz l/iDHeI18IcRyPpP/2YaGUGVrgl02BEoaCHOv+6++XrGBZN9xlxD5XIrN2LYRdHPl2aDjrims IGkvK5VbyOHFjIlViBCe18aGjGEPrqGmAHCcoJDAE5VE1wGzKgNeglgDov6IDawRVQbVx14BM qd5d5Q1bBjHBRvz5SdOz9iJSrFshnEjsO7xf2/ZlJ/j8c+hm4rQ9JBqdz6F+5QkZs4FCiqbCn 9IGiZSPgA0jp5EQskZmGSuxkoWoPHx2kasdKSv9JVEHj8NcQ8SgLQcDTGs5UHYM+hC71YjE3F E0h/qeTMZf2BK7YSWSRlZzUcsl4brnajbp7ZFa557212/56oqMJBi0uHuNhLLUm/PYs0aBNyo 2Th0tuy+JqbGJhtw7zUag+RXtAourRgvn/fpxA5BqBjaI2BUSUHp2Cuo24r4Phpr1tbzAFl08 qpCftSDCnBa/hyyGy/zvRaDcEnns3Lct+W6DFrMq5enZBAmvtqHJyZMHhWxc6RYU6NzbUlzED 3fGW+gyUkXBQM18BAS4lUkUWQbSwvpDroxQ/a9SlksMXayo4ruc0sj5eBrAi6jaNoM5dlueZ3 1RLl+UUCkAqp39qfjEgs0x1yhjAzipSznMnNJxS7lU1ITQ+twezyFM8wWm4LXuCJsOuG8QTVt ggNyGwqNZNufHNBCqI9SFV3lEEwBkGCw+i8sjbuqlVd+qnoIts= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 3 Sep 2017 19:55:25 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/media/pci/saa7146/hexium_orion.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/pci/saa7146/hexium_orion.c b/drivers/media/pci/saa7146/hexium_orion.c index c306a92e8909..72fac6a8494a 100644 --- a/drivers/media/pci/saa7146/hexium_orion.c +++ b/drivers/media/pci/saa7146/hexium_orion.c @@ -223,7 +223,5 @@ static int hexium_probe(struct saa7146_dev *dev) - if (NULL == hexium) { - pr_err("hexium_probe: not enough kernel memory\n"); + if (!hexium) return -ENOMEM; - } /* enable i2c-port pins */ saa7146_write(dev, MC1, (MASK_08 | MASK_24 | MASK_10 | MASK_26)); -- 2.14.1