From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B47193F7A9C for ; Thu, 16 Jul 2026 09:55:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784195706; cv=none; b=agNZGdceeb8IDGkdl0jquHhcsE5s+xVlwkUwtd6D4VTrYMGZ7BLwEiPe/fyux1w+R6myCqUHgI0k5WAj0ATMz8NiVIR7DtBjyQNVU/taIva8KOqV8YaGJyRA/2UHm/FReL+s8HOiD3Xc/tH8qVHVordI2pwzOyPtdLUlMtJuEPg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784195706; c=relaxed/simple; bh=frLm7eDrXLzNQdHNEVt/2yfEvwS7Dqt4TOMUJDhPTIk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LonzMomah/rSu64l9sXLvawP/0B0MNwJtIdzKxDIakrfpc3PJEgCJ5cJug23w3VgM2R4QqLUKHTdu6oy2Wj6xWAjPNzaA1yMuFdP3t7+Cx0GmQc0QYxOJM4sNgTZ23hY6Bw2LMYHVNvDLWmgLKeTIoq2wYG0CU63vgejfvKXHbI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=R+GEu9J9; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R+GEu9J9" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-c082647cd0dso62794666b.0 for ; Thu, 16 Jul 2026 02:55:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784195703; x=1784800503; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZpBD9DlmbjWXiMcbHMb5aTELYylItYcWgKbqrcHcEZc=; b=R+GEu9J95vp9yoopKXEG31obVbLBdH70O4gda9GltKngYK2EJLL+qtXCRNAirlb2kG zHzxl1ERdC6iEEXN8RUsRzEdh6OxQNQP8O0DAr2i+9Bn5u4GRH8CoNexfnNB/oJg5/3c ngRVVTfBoKps2UMPthkBGEgq8PCEprXMp3gxRsyz7kRqaVYC0rcg9Ga+UyL9/ZlkIbVD gkp9L4tC8CRCkQ0WYd58EX7LJnhzixWLPGLW3eP0G0BMdT01LU8ZWo9sRskOybI8Q1hF jYF/Frgb1rqyRw8tP3QdhRKueM7XoIYVTJVx3rJJVT9WjFbf/C6ytBRrLJ6CTgyGqAFx BtyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784195703; x=1784800503; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ZpBD9DlmbjWXiMcbHMb5aTELYylItYcWgKbqrcHcEZc=; b=FVMym2B2WPU16tdBuMa46lYOgc7nS3QUCHuKpMHyFNeGHsgOk18MURJOa2Sn+ZUOHC 5B8UkkPnhBdO041fv3i8MWsYTafZPU/BlTpYekkt0aAzYlfzqOnPUyjo2MQQSLCS8q+E UUDesyEa9qwPa5drv26R3qO9pw8RljNzYt/CjqD56hxiurK7K0Eruwf0+fpKEghwz3O/ 2bAdGsCH0yZ8hfpJhBvjXeLou52mharfhFWiRtWiNpHNxcGYdWn/Vpf/b6m+jhUYzFtR Az0MlKUtQjWakM+H8waGiwe8NpHuwtxtZiOehbPM8zkoHd6GZn8ReADKVZ8/TxUyJZ4z /W5Q== X-Gm-Message-State: AOJu0Ywgh0vnYUUvrwzusbrbhAigJ03LVPop10ZNDjRtsXMyflsQqxq1 POhbovFJb9GXK/wuEaPke/zcDGfpUM+ysGuYSbszq1AMWbJmDRMbHuFr X-Gm-Gg: AfdE7ckz6w5sPmVg8YNgPQ9DDIidPFt6VkvEDy5aUMsKmzpqcP2+fmo6BhjR6xaC0Py LwK74AmEbAIat24DNUycpc6TsVP37DCTQ9znnx7Y8sXZYLpRuvaWqeqsmFPwICLtCAO77V8C0ev C9cRVJbDkL7cLkbO+QRLqt0WqmTfhE/eYoD3nOPsatEUUYEd2ZtyXSGKZVcl4qaxfGjYhodWas7 oMRMvcFkhur2sbTMlY6RNkHIQNN6jHqhX0IN6xqxc9TSACC2C6RvvkGxgqSoZc7nQ2oQjifsSBR R+XCebJAEJBrVMDoFzd50u9ZDrc9+HFOjebBDWb45VuF9gX6rUmOgoLnl/fkOFpMBktyKRJG+C0 WumHRJ1E8cZNpfB0D4iQejvlqblNlXAgwohlurCNUOPQpN/3lFQgWZWL9hjKmsPed4fqU X-Received: by 2002:a17:906:ee8c:b0:c15:f4bb:e665 with SMTP id a640c23a62f3a-c161ea8d628mr707638766b.5.1784195702614; Thu, 16 Jul 2026 02:55:02 -0700 (PDT) Received: from fridge ([193.32.127.173]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c168744e702sm178454966b.47.2026.07.16.02.55.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2026 02:55:02 -0700 (PDT) From: Emre Cecanpunar To: platform-driver-x86@vger.kernel.org, hansg@kernel.org, ilpo.jarvinen@linux.intel.com Cc: linux-kernel@vger.kernel.org, krishna.chomal108@gmail.com, radheykalra901@gmail.com, edip@medip.dev, hello@kursatabayli.dev, mjg59@srcf.ucam.org, akpm@linux-foundation.org, jorge.lopez2@hp.com, jes965@nyu.edu, mario.limonciello@amd.com, julien.robin28@free.fr, Emre Cecanpunar Subject: [PATCH 3/5] platform/x86: hp-wmi: handle errors in the OMEN key event Date: Thu, 16 Jul 2026 12:54:16 +0300 Message-ID: <80d2021166a4e71453d366012598f5f4ac2f2c34.1784195117.git.emreleno@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit hp_wmi_read_int() can return a negative error code, but the HPWMI_OMEN_KEY handler passes it directly to sparse_keymap_report_event(). The value is then converted to an unsigned key code, causing a bogus lookup and a KEY_UNKNOWN input event. Stop processing the event when reading the key code fails, mirroring the existing check in the HPWMI_BEZEL_BUTTON handler. Fixes: f4a31a428d0d ("platform/x86: hp-wmi: Add HP Envy special key support") Signed-off-by: Emre Cecanpunar --- drivers/platform/x86/hp/hp-wmi.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c index e226b772ef00..29881749aae6 100644 --- a/drivers/platform/x86/hp/hp-wmi.c +++ b/drivers/platform/x86/hp/hp-wmi.c @@ -1253,10 +1253,14 @@ static void hp_wmi_notify(union acpi_object *obj, void *context) platform_profile_cycle(); break; case HPWMI_OMEN_KEY: - if (event_data) /* Only should be true for HP Omen */ + if (event_data) { + /* Only should be true for HP Omen */ key_code = event_data; - else + } else { key_code = hp_wmi_read_int(HPWMI_HOTKEY_QUERY); + if (key_code < 0) + break; + } if (!sparse_keymap_report_event(hp_wmi_input_dev, key_code, 1, true))