Re: [PATCH] ALSA: hda/tegra: Re-enable SDO workaround for Tegra194

[Jon Hunter <jonathanh@nvidia.com>]

On 26/09/2026 08:24, Aaron Kling via B4 Relay wrote:
> From: Aaron Kling <webgeek1234@gmail.com>
> 
> This workaround was originally added for Tegra194, but no longer gets
> applied for it. Commit 615d43540043 ("ALSA: hda/tegra: fix tegra-hda on
> tegra30 soc") changed the guard to tegra30-hda, which worked because all
> affected archs had the fallback compatible. However, commit 7f0ea5acfc19
> ("arm64: tegra: Use correct compatible string for Tegra194 HDA") removed
> the fallback compatible for Tegra194, causing this to break.
> 
> Fixes: 7f0ea5acfc19 ("arm64: tegra: Use correct compatible string for Tegra194 HDA")
> Cc: stable@vger.kernel.org
> Assisted-by: LLM
> Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> ---
> ALSA: hda/tegra: Re-enable SDO workaround for Tegra194
> ---
>   sound/hda/controllers/tegra.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/hda/controllers/tegra.c b/sound/hda/controllers/tegra.c
> index 31c14c4bbe683..674cc0f79c3c8 100644
> --- a/sound/hda/controllers/tegra.c
> +++ b/sound/hda/controllers/tegra.c
> @@ -374,7 +374,8 @@ static int hda_tegra_first_init(struct azx *chip, struct platform_device *pdev)
>   	 * in powers of 2, next available ratio is 16 which can be
>   	 * used as a limiting factor here.
>   	 */
> -	if (of_device_is_compatible(np, "nvidia,tegra30-hda"))
> +	if (of_device_is_compatible(np, "nvidia,tegra30-hda") ||
> +	    of_device_is_compatible(np, "nvidia,tegra194-hda"))
>   		chip->bus.core.sdo_limit = 16;
>   
>   	/* codec detection */
> 
> ---
> base-commit: 4c253ac4b29b8c6cc6fdef8f92d4facde62e63b9
> change-id: 20260926-tegra194-hda-sdo-1d84c6085198
I would be tempted to change the fixes tag to be 615d43540043
("ALSA: hda/tegra: fix tegra-hda on tegra30 soc") because technically
the Tegra194 device-tree was incorrect and after commit 615d43540043
is present, we always want the above. Otherwise ...

Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Thanks!
Jon

-- 
nvpublic