From: Hans Verkuil <hverkuil@xs4all.nl>
To: Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@gmail.com>,
laurent.pinchart@ideasonboard.com, mchehab@kernel.org,
gregkh@linuxfoundation.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy-kernel@googlegroups.com
Subject: Re: [PATCH 2/2] staging: media: omap4iss: align arguments with open parenthesis
Date: Wed, 7 Apr 2021 17:23:40 +0200 [thread overview]
Message-ID: <80d633de-180e-6b2c-e75b-7e32116a078e@xs4all.nl> (raw)
In-Reply-To: <475dbbe5774cbfed2d924807d8a3cfeb84b3d845.1617287509.git.martinsdecarvalhobeatriz@gmail.com>
Hi Beatriz,
On 01/04/2021 17:07, Beatriz Martins de Carvalho wrote:
> Cleans up checks of "Alignment should match open parenthesis"
> in iss.c:96.
Looks good. I'll take this patch.
You can use this reference to record your contribution:
https://patchwork.linuxtv.org/project/linux-media/patch/475dbbe5774cbfed2d924807d8a3cfeb84b3d845.1617287509.git.martinsdecarvalhobeatriz@gmail.com/
The state will change to Accepted once it is merged in our media tree
here: https://git.linuxtv.org/media_tree.git/log/
Regards,
Hans
>
> Signed-off-by: Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@gmail.com>
> ---
> drivers/staging/media/omap4iss/iss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c
> index e8f724dbf810..472f1837632e 100644
> --- a/drivers/staging/media/omap4iss/iss.c
> +++ b/drivers/staging/media/omap4iss/iss.c
> @@ -963,7 +963,7 @@ iss_register_subdev_group(struct iss_device *iss,
> }
>
> subdev = v4l2_i2c_new_subdev_board(&iss->v4l2_dev, adapter,
> - board_info->board_info, NULL);
> + board_info->board_info, NULL);
> if (!subdev) {
> dev_err(iss->dev, "Unable to register subdev %s\n",
> board_info->board_info->type);
>
next prev parent reply other threads:[~2021-04-07 15:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 15:07 [PATCH 0/2] staging: media: omap4iss: Patchsets cleans up in iss.c Beatriz Martins de Carvalho
2021-04-01 15:07 ` [PATCH 1/2] staging: media: omap4iss: Ending line with argument Beatriz Martins de Carvalho
2021-04-01 15:28 ` [Outreachy kernel] " Matthew Wilcox
2021-04-07 10:00 ` Beatriz Martins de Carvalho
2021-04-07 10:15 ` Julia Lawall
2021-04-07 13:46 ` Hans Verkuil
2021-04-07 14:19 ` Beatriz Martins de Carvalho
2021-04-01 15:07 ` [PATCH 2/2] staging: media: omap4iss: align arguments with open parenthesis Beatriz Martins de Carvalho
2021-04-01 15:29 ` [Outreachy kernel] " Matthew Wilcox
2021-04-07 15:23 ` Hans Verkuil [this message]
2021-04-01 15:25 ` [PATCH 0/2] staging: media: omap4iss: Patchsets cleans up in iss.c Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80d633de-180e-6b2c-e75b-7e32116a078e@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=gregkh@linuxfoundation.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martinsdecarvalhobeatriz@gmail.com \
--cc=mchehab@kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®