From: David Decotigny <david.decotigny@google.com>
To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Ian Campbell <ian.campbell@citrix.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Ben Hutchings <bhutchings@solarflare.com>,
Jiri Pirko <jpirko@redhat.com>, Joe Perches <joe@perches.com>,
Szymon Janc <szymon@janc.net.pl>,
David Decotigny <david.decotigny@google.com>
Subject: [PATCH net-next v2 09/10] forcedeth: stats updated with a deferrable timer
Date: Thu, 10 Nov 2011 17:31:34 -0800 [thread overview]
Message-ID: <80db4aefe8d8a74d15a98c7ae72c4c8c8e469ca6.1320974990.git.david.decotigny@google.com> (raw)
In-Reply-To: <cover.1320974990.git.david.decotigny@google.com>
In-Reply-To: <cover.1320974990.git.david.decotigny@google.com>
Mark stats timer as deferrable: punctuality in waking the stats timer
callback doesn't matter much, as it is responsible only to avoid
integer wraparound.
We need at least 1 other timer to fire within 17s (fully loaded 1Gbps)
to avoid wrap-arounds. Desired period is still 10s.
Signed-off-by: David Decotigny <david.decotigny@google.com>
---
drivers/net/ethernet/nvidia/forcedeth.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/nvidia/forcedeth.c b/drivers/net/ethernet/nvidia/forcedeth.c
index 7813c37..3617ba3 100644
--- a/drivers/net/ethernet/nvidia/forcedeth.c
+++ b/drivers/net/ethernet/nvidia/forcedeth.c
@@ -5377,7 +5377,7 @@ static int __devinit nv_probe(struct pci_dev *pci_dev, const struct pci_device_i
init_timer(&np->nic_poll);
np->nic_poll.data = (unsigned long) dev;
np->nic_poll.function = nv_do_nic_poll; /* timer handler */
- init_timer(&np->stats_poll);
+ init_timer_deferrable(&np->stats_poll);
np->stats_poll.data = (unsigned long) dev;
np->stats_poll.function = nv_do_stats_poll; /* timer handler */
--
1.7.3.1
next prev parent reply other threads:[~2011-11-11 1:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-11 1:31 [PATCH net-next v2 00/10] forcedeth: stats & debug enhancements David Decotigny
2011-11-11 1:31 ` [PATCH net-next v2 01/10] forcedeth: fix ifconfig stats on hardware without extended stats support David Decotigny
2011-11-11 1:31 ` [PATCH net-next v2 02/10] forcedeth: Add messages to indicate using MSI or MSI-X David Decotigny
2011-11-11 1:31 ` [PATCH net-next v2 03/10] forcedeth: allow to silence "TX timeout" debug messages David Decotigny
2011-11-11 1:31 ` [PATCH net-next v2 04/10] forcedeth: expose module parameters in /sys/module David Decotigny
2011-11-11 1:31 ` [PATCH net-next v2 05/10] forcedeth: stats for rx_packets based on hardware registers David Decotigny
2011-11-11 1:31 ` [PATCH net-next v2 06/10] forcedeth: implement ndo_get_stats64() API David Decotigny
2011-11-11 1:31 ` [PATCH net-next v2 07/10] forcedeth: account for dropped RX frames David Decotigny
2011-11-11 1:31 ` [PATCH net-next v2 08/10] forcedeth: new ethtool stat counter for TX timeouts David Decotigny
2011-11-11 1:31 ` David Decotigny [this message]
2011-11-11 1:31 ` [PATCH net-next v2 10/10] forcedeth: whitespace/indentation fixes David Decotigny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80db4aefe8d8a74d15a98c7ae72c4c8c8e469ca6.1320974990.git.david.decotigny@google.com \
--to=david.decotigny@google.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=ian.campbell@citrix.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=joe@perches.com \
--cc=jpirko@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=szymon@janc.net.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®