From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F19BB3C2774 for ; Wed, 18 Mar 2026 13:17:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773839859; cv=none; b=NGXu9j+/NzRFljyZ4+/QgwGKeXGCfcCEWSD5ehp/DZ3e5es2j4FdQT9jvKnNELPv9WP6JbksY1JvBtbQqzHy7hasktU2DfxW6lyKQX+sfgJSHKpW7Z1zQ1UWBAH6aZyuT7INVlfMzkI2Sb8IjJgSG7ajipbFT/JXibiMALzMZPY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773839859; c=relaxed/simple; bh=34vfCXW8oRGGcaBK9jaqcMWl8InMuT5iFBjmXmD8BI4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dz934kXycPMmP0oh7iF3M785PrvMIp0bcqi0BHCEF3yf7SySFFAgQ9LW1EeZb9toc+H4mpmKB8kJ8BE7DP0K+9EnTJWyMAkd8c1EGAPpXasxjmEUQFJn+9OI52SLHa0Bs6Q4XGMyT/GuY/OoLoItKsPo18J5Ml1In0yaxHndUUk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=VebEEn84; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VebEEn84" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4852f8ac7e9so80836875e9.1 for ; Wed, 18 Mar 2026 06:17:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773839856; x=1774444656; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lY+vBk+jrr/WsrbU3NBPrdruLfUU1yCebVSPO/aA9bU=; b=VebEEn84oYgbCGvkB8OC74hU3WZiCDsgK50wX9AhQnk4KdsoaA4CxCQhv7Ccb+Rgv0 P01egR1+KMxW87xi4+OZBorX1sQFmf6BT0PjuVzzdXvM1WoAhyfVSw/WJvNLqddmvuJG RbTc8gGPfbiGyZd1F7i1oHSBSk+BQFORiZwWzPMKUIwEXT5XCnNOi31047dujwAdd0gR ZokS7beMVDjPH9BP7VYzJfFcFfzj8HRt5L4Bk5sOUsrQdnvPIE0VkY1gBotfB0KcseF3 Eo6Ifc5m20nftWM1EwIoXVSglueowgFwrETWMOBRJ1mtcxjCjgVV5yqKZbxsLLzv/VGy a0vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773839856; x=1774444656; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lY+vBk+jrr/WsrbU3NBPrdruLfUU1yCebVSPO/aA9bU=; b=p5k5JpdZhwTFNe3dltG3sQunSW/9MahhSxG3Pv2YtrWk5pGkWwFfqxmYpVsC+LTDkX eWJIofg+Na3LPamcibNR0Phc5hIZxAQ0GOE/OQUQ+1qmRZb9RxA6bdjPUMlCyrlvDM58 lmkpS4MBe6sm6NUkuaghPpdFJfX1QaeTRzw5E96FobF2sPAZculGQittGwMc9fXgaNaa vQ2x45mBBN2a7vkiIMcuZD4WWMf7eWsy5zbw1F7bRI3uHvx4fA2sOu9F1fSRu9U7c7of EL2Ksm6BYurixmxpBHQoFaW8jNXn9nlBz/TKVRW/jesXyDpMJAWb2yQJB76MTKdZi2Rt 9bnw== X-Forwarded-Encrypted: i=1; AJvYcCU5WZ8dWwxLsTd7nNiCg5DO+FBKB7rYIa/VVsvpDqfzNJ8txKDblrSt/DuDYYeIXj97ERCZTCoanV4nfS0=@vger.kernel.org X-Gm-Message-State: AOJu0YxZ7qV2EOz823ZgjTMQPzZjSQtln2Gi7e/XAbTqXtoOfkHjekHL ZXjDz726uybnst5w8L1YyTXWxV1qCPrU7OrkJkb9wPVZJPt0C0xpsOZvbsEo5JHbJ+I= X-Gm-Gg: ATEYQzxBYH2uX8RUy2cBkPfvnPfAx9xSNisXTSv4x0o4iyHdzDBOYt6MgC81/5U1yuD 88CRlBjbL4HQR1Zd1ZohA8PMMW7ryTAZt/fPo7F2OMkiA2sFqPJEmatIv1vgKvVyyesR1mQhb1d 75rWL8+7AH7q+aL8aH2wVKn2Yuggei8ycTZGXOajbnRFkf5aOgHsHYBhJxQZbRmnFZYNq8h6+ip JNi5kKa15QL71G3gysigGpyHpEydqbCXIg+Nt97E+FQSMGJbf0GTQcI38WdmmUExCmq0O2f6TCX LGy5eml9hjvO2ok48seuyNy+aBUm7zpE6h+BjZN9mYdFyuD5+pzMK+QcLuhlIxe7/xpo1rgN1Tv vvrK8Do9+M3PYWTehSzwacETzyiKpsExYNJVpJlynW1Bwl5S06cRhKXoFxMrbfs1XpETvSaDJrB uG/R8lWmIXo88FS7byqw5KyqxXNRW2TENsjA== X-Received: by 2002:a05:600c:1d0c:b0:485:3cf3:1010 with SMTP id 5b1f17b1804b1-486f442e5d6mr56422235e9.2.1773839856267; Wed, 18 Mar 2026 06:17:36 -0700 (PDT) Received: from [192.168.0.167] ([109.76.1.114]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f4b9bb2esm18004555e9.20.2026.03.18.06.17.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2026 06:17:35 -0700 (PDT) Message-ID: <80ddc2b4-d6f8-4e8d-a45e-69c05d100aa2@linaro.org> Date: Wed, 18 Mar 2026 13:17:33 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/2] phy: qcom-mipi-csi2: Add a CSI2 MIPI DPHY driver To: Neil Armstrong , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Bryan O'Donoghue , Vladimir Zapolskiy , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260315-x1e-csi2-phy-v4-0-90c09203888d@linaro.org> <20260315-x1e-csi2-phy-v4-2-90c09203888d@linaro.org> <3f11de22-b729-4d06-b6c8-18e649e1979c@linaro.org> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <3f11de22-b729-4d06-b6c8-18e649e1979c@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 18/03/2026 10:15, Neil Armstrong wrote: >> +    /* >> +     * phy_configure_opts_mipi_dphy.lanes starts from zero to >> +     * the maximum number of enabled lanes. >> +     * >> +     * TODO: add support for bitmask of enabled lanes and polarities >> +     * of those lanes to the phy_configure_opts_mipi_dphy struct. >> +     * For now take the polarities as zero and the position as fixed >> +     * this is fine as no current upstream implementation maps >> otherwise. >> +     */ > > This is wrong since you loose the lanes mapping defined in DT, which is > still in CAMSS > but is a PHY property. The lanes layout is not a property of the CSI > controller, > CSI controller only need to know the lanes count, and not the layout. Lane layout is a PHY concern but, the PHY API gives us phy_configure_opts_mipi_dphy which should be extended to provide layout and polarity. This would then be of benefit to more than just qcom/camss. Right now none of the CAMSS users for this driver depend on any other mapping and I propose a separate series to fix phy_configure_opts_mipi_dphy rather than introduce data-lanes to DPHY. --- bod