From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 06CD639B489 for ; Fri, 24 Jul 2026 06:58:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784876328; cv=none; b=ZTlL/mhd1Cbx8RnERmkPhVqBTLmXDh1fG+9o8ADLFZMFUa8MhhA4Z+HJqUf9IZcWeXNLpJv+ISiSjx8/32MxyTMudMD90c7yndVMvbcJNAgE5/U/RBPBaOV5iekuwD+T2rskdzfD0dgYNYaXPo2EfPau1IG7yVyeAodWkh8I/5w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784876328; c=relaxed/simple; bh=8opUrBathN15FxyeocWaiA2NOoTsRtqjm5INeSzIm0o=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=oj0yaJ/mQ3Zl4xredVGBPEpb3hcqrcB9fHfRuvnN1+ypsXC2xTYiok4Uvaj1UJL4I14J6uX/EPqIEDN4Bg1en1DF0TrZMhXZ+R8XyZQIdehNLECog5Oq5K+5h9cHh7jijH12hRlq7UB2F591DNRTpNAhiWSYCr88seIG77G678g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=MzoxcISB; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="MzoxcISB" Received: from [10.94.177.11] (unknown [4.194.122.162]) by linux.microsoft.com (Postfix) with ESMTPSA id BFA1A20B7167; Thu, 23 Jul 2026 23:58:30 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com BFA1A20B7167 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1784876312; bh=XCvccBUeoX+oNuUl2AWHh4+obwjkgVsuQu28g3eZOAE=; h=Date:Subject:To:References:From:In-Reply-To:From; b=MzoxcISBtFMSm6zP5y82pd91jg0T/9OVQh5+au/CzTWY/YTXfnC7e/TtzpBefbpoF 1Aui+MaNRkFSLqZviiJGTRl5KO2qMKTBalR1yY2POwHTXqy1E/uVQBdSeZrl8w00VD UHsXOox8iQYc9vYZm+g7fkaUAIu9O7HZ1dMOsTe8= Message-ID: <80e19216-46d1-495f-8e2e-85101df3b284@linux.microsoft.com> Date: Fri, 24 Jul 2026 12:28:43 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] soc: xilinx: Remove redundant dev_err() To: Pan Chuang , Michal Simek , Radhey Shyam Pandey , Marco Crivellari , Jay Buddhabhatti , "moderated list:ARM/ZYNQ ARCHITECTURE" , open list References: <20260723022857.627844-1-panchuang@vivo.com> Content-Language: en-US From: Prasanna Kumar T S M In-Reply-To: <20260723022857.627844-1-panchuang@vivo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 23-07-2026 07:58, Pan Chuang wrote: > Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in > devm_request_*_irq()"), devm_request_threaded_irq() automatically logs > detailed error messages on failure. Remove the now-redundant > driver-specific dev_err() calls. > > Signed-off-by: Pan Chuang > Reviewed-by: Radhey Shyam Pandey > Acked-by: Michal Simek > --- > drivers/soc/xilinx/zynqmp_power.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/soc/xilinx/zynqmp_power.c b/drivers/soc/xilinx/zynqmp_power.c > index 370e61ac47d8..54c796afb89e 100644 > --- a/drivers/soc/xilinx/zynqmp_power.c > +++ b/drivers/soc/xilinx/zynqmp_power.c > @@ -368,11 +368,8 @@ static int zynqmp_pm_probe(struct platform_device *pdev) > IRQF_NO_SUSPEND | IRQF_ONESHOT, > dev_name(&pdev->dev), > &pdev->dev); > - if (ret) { > - dev_err(&pdev->dev, "devm_request_threaded_irq '%d' failed with %d\n", > - irq, ret); > + if (ret) > return ret; > - } > } else { > dev_err(&pdev->dev, "Required property not found in DT node\n"); > return -ENOENT; Looks good to me. Reviewed-by: Prasanna Kumar T S M