From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Yang Xiwen <forbidden405@outlook.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: David Yang <mmyangfl@gmail.com>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/8] dt-bindings: clock: histb-clock: split into two header files
Date: Thu, 22 Feb 2024 19:19:33 +0100 [thread overview]
Message-ID: <80e3b597-1273-4391-9aa5-72e2a9e76e57@linaro.org> (raw)
In-Reply-To: <SEZPR06MB695934C69446B4878115B17796562@SEZPR06MB6959.apcprd06.prod.outlook.com>
On 22/02/2024 19:15, Yang Xiwen wrote:
> On 2/23/2024 2:11 AM, Krzysztof Kozlowski wrote:
>> On 21/02/2024 17:41, Yang Xiwen via B4 Relay wrote:
>>> From: Yang Xiwen <forbidden405@outlook.com>
>>>
>>> The CRG driver between different SoCs provides different clocks and
>>> resets. We should not provide a generic header file across all HiSTB
>>> SoCs, instead each CRG driver should provide its own.
>>>
>>> Split histb-clock.h into two files: hisilicon,hi3798cv200-crg.h and
>>> hisilicon,hi3798cv200-sysctrl.h. This header file is for Hi3798CV200
>>> only actually. For other HiSTB SoCs, some clock definitions are missing.
>>>
>>> Create a new histb-clock.h to include these two files for backward
>>> compatibility only. Deprecate this file as well.
>>>
>>> Signed-off-by: Yang Xiwen <forbidden405@outlook.com>
>>> ---
>>> .../dt-bindings/clock/hisilicon,hi3798cv200-crg.h | 62 ++++++++++++++++++
>>> .../clock/hisilicon,hi3798cv200-sysctrl.h | 17 +++++
>>> include/dt-bindings/clock/histb-clock.h | 73 +++-------------------
>>> 3 files changed, 87 insertions(+), 65 deletions(-)
>
>
> Should I fix the #ifndef #define #endif stuffs here? i.e. s/DTS/DT_BINDING
I would not care. But new files could be correct.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-02-22 18:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 16:41 [PATCH v3 0/8] clk: hisilicon: add support for Hi3798MV200 Yang Xiwen via B4 Relay
2024-02-21 16:41 ` [PATCH v3 1/8] dt-bindings: clock: convert hisi-crg.txt to YAML Yang Xiwen via B4 Relay
2024-02-22 18:06 ` Krzysztof Kozlowski
2024-02-22 18:08 ` Yang Xiwen
2024-02-21 16:41 ` [PATCH v3 2/8] ARM: dts: hisilicon: add missing compatibles to CRG node Yang Xiwen via B4 Relay
2024-02-22 18:08 ` Krzysztof Kozlowski
2024-02-22 18:13 ` Yang Xiwen
2024-02-22 18:18 ` Krzysztof Kozlowski
2024-02-22 18:24 ` Yang Xiwen
2024-02-21 16:41 ` [PATCH v3 3/8] dt-bindings: clock: histb-clock: split into two header files Yang Xiwen via B4 Relay
2024-02-22 18:11 ` Krzysztof Kozlowski
2024-02-22 18:15 ` Yang Xiwen
2024-02-22 18:19 ` Krzysztof Kozlowski [this message]
2024-02-22 18:19 ` Krzysztof Kozlowski
2024-02-21 16:41 ` [PATCH v3 4/8] arm64: dts: hisilicon: fix include path Yang Xiwen via B4 Relay
2024-02-21 16:41 ` [PATCH v3 5/8] clk: hisilicon: fix include path for crg-hi3798cv200 Yang Xiwen via B4 Relay
2024-02-21 16:41 ` [PATCH v3 6/8] dt-bindings: clock: hisilicon,clock-reset-controller: add Hi3798MV200 SoC Yang Xiwen via B4 Relay
2024-02-21 16:41 ` [PATCH v3 7/8] dt-bindings: clock: hisilicon: add clock definitions for Hi3798MV200 Yang Xiwen via B4 Relay
2024-02-22 18:10 ` Krzysztof Kozlowski
2024-02-21 16:41 ` [PATCH v3 8/8] clk: hisilicon: add CRG driver for Hi3798MV200 SoC Yang Xiwen via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80e3b597-1273-4391-9aa5-72e2a9e76e57@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=forbidden405@outlook.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmyangfl@gmail.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®