From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2363426AFC for ; Mon, 24 Mar 2025 15:20:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.196 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742829612; cv=none; b=KcxP2JVPYbPeYsyTYxK5VxsIZvk30d/2x5nUuGHHENAigeXFgYAYKJfwiHb/oWvs/PijcM4YObGKnIHxBIrlH6CrwgiBBWuy/UVTWqMv/f5vjUNOrOMT6kwr2nmGhXgOdb0AfIRxvNNuAqiGDrV3YpJDhCQieMT1JNzusGwuXDM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742829612; c=relaxed/simple; bh=J8i6w4wHFIHRW749vcKhmCwWnV+XJUWyY6zBOiHIDU0=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=Ou8QLcVptVP4IY7n9vzSHIYkDJp56WoFRQ/rX9mUgk3rvTGQniyRQbOFVXmr31x34esA3leO0KMgod+CK+s4sAChyfmVGaveG1/s/k7JJf40H6rl338ToYhsy7XuvsVFufGBFapX256brZVpQA9du2dI8zpWt0QNi49UnXEkTTg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=XBUSDQA1; arc=none smtp.client-ip=217.70.183.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="XBUSDQA1" Received: by mail.gandi.net (Postfix) with ESMTPSA id 94BA144521; Mon, 24 Mar 2025 15:20:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1742829608; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=64cGfJX2CUfwKXlibv/gVIOSuJtuUlaHPjewtQM7FkA=; b=XBUSDQA1p6h43VO1cpZVHe7SdMc0N2tw5im0y5oSOqjX4uPR68MDOJL6T8TqR7VmCh6iWM SJQZjJPl6U7QduJdtlQdnpnWv18rJpxKbtUqfoJhezcX84FbdsqmT8TbNPBHtJDE/NyaFA dZZodrI6FtULgstofnlcRhWw2643/dGr+R1YvvqeF5qVrAFPhC+xE+yAy+pwektrnON/uf Dt44JQNpOZdCnYSPxaf7vRB2Y3Gs9Ve9VIEXrFuHUBjv2H+4AZNDBkGxvgGQY58WJLEZkU 2K3NLQIJAtORAqLzZYB5Tf8KY/JU39i2uvWwkrnxvqVpkfiQWd8CGghOGpZJKw== Message-ID: <80e58693-8ca0-4bce-b7b3-bf0302d0825c@bootlin.com> Date: Mon, 24 Mar 2025 16:20:04 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Louis Chauvet Subject: Re: [PATCH v2 28/59] selftests-dyndbg: add test_mod_submod To: Jim Cromie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-gfx-trybot@lists.freedesktop.org Cc: jbaron@akamai.com, gregkh@linuxfoundation.org, ukaszb@chromium.org, daniel.vetter@ffwll.ch, tvrtko.ursulin@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com References: <20250320185238.447458-1-jim.cromie@gmail.com> <20250320185238.447458-29-jim.cromie@gmail.com> Content-Language: en-US Autocrypt: addr=louis.chauvet@bootlin.com; keydata= xsFNBGCG5KEBEAD1yQ5C7eS4rxD0Wj7JRYZ07UhWTbBpbSjHjYJQWx/qupQdzzxe6sdrxYSY 5K81kIWbtQX91pD/wH5UapRF4kwMXTAqof8+m3XfYcEDVG31Kf8QkJTG/gLBi1UfJgGBahbY hjP40kuUR/mr7M7bKoBP9Uh0uaEM+DuKl6bSXMSrJ6fOtEPOtnfBY0xVPmqIKfLFEkjh800v jD1fdwWKtAIXf+cQtC9QWvcdzAmQIwmyFBmbg+ccqao1OIXTgu+qMAHfgKDjYctESvo+Szmb DFBZudPbyTAlf2mVKpoHKMGy3ndPZ19RboKUP0wjrF+Snif6zRFisHK7D/mqpgUftoV4HjEH bQO9bTJZXIoPJMSb+Lyds0m83/LYfjcWP8w889bNyD4Lzzzu+hWIu/OObJeGEQqY01etOLMh deuSuCG9tFr0DY6l37d4VK4dqq4Snmm87IRCb3AHAEMJ5SsO8WmRYF8ReLIk0tJJPrALv8DD lnLnwadBJ9H8djZMj24+GC6MJjN8dDNWctpBXgGZKuCM7Ggaex+RLHP/+14Vl+lSLdFiUb3U ljBXuc9v5/9+D8fWlH03q+NCa1dVgUtsP2lpolOV3EE85q1HdMyt5K91oB0hLNFdTFYwn1bW WJ2FaRhiC1yV4kn/z8g7fAp57VyIb6lQfS1Wwuj5/53XYjdipQARAQABzSlMb3VpcyBDaGF1 dmV0IDxsb3Vpcy5jaGF1dmV0QGJvb3RsaW4uY29tPsLBlAQTAQgAPgIbAwULCQgHAgYVCgkI CwIEFgIDAQIeAQIXgBYhBItxBK6aJy1mk/Un8uwYg/VeC0ClBQJmlnw+BQkH8MsdAAoJEOwY g/VeC0ClyhwP/Ra6H+5F2NEW6/IMVHeXmhuly8CcZ3kyoKeGNowghIcTBo59dFh0atGCvr+y K9YD5Pyg9aX4Ropw1R1RVIMrWoUNZUKebRTu6iNHkE6tmURJaKLzR+9la+789jznQvbV+9gM YTBppX4/0cWY58jiDiDV4aJ77JDo7aWNK4hz8mZsB+Y7ezMuS4jy2r4b7dZ+YL/T9/k3/emO PkAuFkVhkNhytMEyOBsT7SjL4IUBeYWvOw9MIaXEl4qW/5HLGtMuNhS94NsviDXZquoOHOby 2uuRAI0bLz1qcsnY90yyPlDJ0pMuJHbi0DBzPTIYkyuwoyplfWxnUPp1wfsjiy/B6mRKTbdE a/K6jNzdVC1LLjTD4EjwnCE8IZBRWH1NVC1suOkw3Sr1FYcHFSYqNDrrzO+RKtR1JMrIe8/3 Xhe2/UNUhppsK3SaFaIsu98mVQY3bA/Xn9wYcuAAzRzhEHgrbp8LPzYdi6Qtlqpt4HcPV3Ya H9BkCacgyLHcdeQbBXaup9JbF5oqbdtwev3waAmNfhWhrQeqQ0tkrpJ46l9slEGEdao5Dcct QDRjmJz7Gx/rKJngQrbboOQz+rhiHPoJc/n75lgOqtHRePNEf9xmtteHYpiAXh/YNooXJvdA tgR1jAsCsxuXZnW2DpVClm1WSHNfLSWona8cTkcoSTeYCrnXzsFNBGCG6KUBEADZhvm9TZ25 JZa7wbKMOpvSH36K8wl74FhuVuv7ykeFPKH2oC7zmP1oqs1IF1UXQQzNkCHsBpIZq+TSE74a mG4sEhZP0irrG/w3JQ9Vbxds7PzlQzDarJ1WJvS2KZ4AVnwc/ucirNuxinAuAmmNBUNF8w6o Y97sdgFuIZUP6h972Tby5bu7wmy1hWL3+2QV+LEKmRpr0D9jDtJrKfm25sLwoHIojdQtGv2g JbQ9Oh9+k3QG9Kh6tiQoOrzgJ9pNjamYsnti9M2XHhlX489eXq/E6bWOBRa0UmD0tuQKNgK1 n8EDmFPW3L0vEnytAl4QyZEzPhO30GEcgtNkaJVQwiXtn4FMw4R5ncqXVvzR7rnEuXwyO9RF tjqhwxsfRlORo6vMKqvDxFfgIkVnlc2KBa563qDNARB6caG6kRaLVcy0pGVlCiHLjl6ygP+G GCNfoh/PADQz7gaobN2WZzXbsVS5LDb9w/TqskSRhkgXpxt6k2rqNgdfeyomlkQnruvkIIjs Sk2X68nwHJlCjze3IgSngS2Gc0NC/DDoUBMblP6a2LJwuF/nvaW+QzPquy5KjKUO2UqIO9y+ movZqE777uayqmMeIy4cd/gg/yTBBcGvWVm0Dh7dE6G6WXJUhWIUtXCzxKMmkvSmZy+gt1rN OyCd65HgUXPBf+hioCzGVFSoqQARAQABwsOyBBgBCAAmAhsuFiEEi3EErponLWaT9Sfy7BiD 9V4LQKUFAmaWfGYFCQfwx0ECQAkQ7BiD9V4LQKXBdCAEGQEIAB0WIQRPj7g/vng8MQxQWQQg rS7GWxAs4gUCYIbopQAKCRAgrS7GWxAs4gfGEACcA0XVNesbVIyvs5SJpJy+6csrH4yy233o GclX2P7pcCls55wiV6ywCtRaXWFjztYmklQieaZ/zq+pUuUDtBZo95rUP20E56gYV2XFB18W YeekTwH5d2d/j++60iHExWTB+sgMEv3CEGikUBj7iaMX2KtaB1k9K+3K6dx/s1KWxOClFkbJ EV/tmeq7Ta8LiytQM9b4yY550tzC0pEEeFcLFXo1m5KcJauYnAqrlOVY48NFpFUd9oAZf/Pz p3oEs+zn/8zK2PBrZZCD6AhrbotRy7irE5eimhxcsFm1+MG5ufnaQUWHrRYXVuFhvkSoqZ8j GPgPEpFor4NjRyX/PMLglQ7S5snkvKcr3Lun44aybXEHq/1FTzW2kOh6kFHFFOPbMv1voJKM IzrmDoDS+xANt/La7OwpCylCgF6t9oHHTTGfAfwtfYZbiepC66FDe/Jt/QLwkIXeIoeSS1O4 6rJdGWG2kHthUM+uIbUbaRJW8AkJpzP1Mz7TieR/9jO4YPeUm9tGL5kP2yyNtzFilcoOeox1 NSFNAPz+zPcovVmxAaSDGcSzhQVJVlk8xPib8g4fnI8qJ3Gj7xyw8D9dzxhCR2DIFmZL84En N7Rj+k4VIGY7M/cVvxL81jlbMGMERMmb96Cua9z1ROviGA1He2gbHOcp6qmLNu3nprleG8PL ZRNdEAC0iZapoyiXlVCKLFIwUPnxUz5iarqIfQU8sa1VXYYd/AAAFI6Wv3zfNtGicjgHP8rN CIegqm2Av1939XXGZJVI9f3hEoUn04rvxCgcDcUvn7I0WTZ4JB9G5qAGvQLXeXK6Byu77qTx eC7PUIIEKN3X47e8xTSj2reVTlanDr8yeqZhxpKHaS0laF8RbD85geZtAK67qEByX2KC9DUo eHBFuXpYMzGQnf2SG105ePI2f4h5iAfbTW9VWH989fx4f2hVlDwTe08/NhPdwq/Houov9f/+ uPpYEMlHCNwE8GRV7aEjd/dvu87PQPm4zFtC3jgQaUKCbYYlHmYYRlrLQenX3QSorrQNPbfz uQkNLDVcjgD2fxBpemT7EhHYBz+ugsfbtdsH+4jVCo5WLb/HxE6o5zvSIkXknWh1DhFj/qe9 Zb9PGmfp8T8Ty+c/hjE5x6SrkRCX8qPXIvfSWLlb8M0lpcpFK+tB+kZlu5I3ycQDNLTk3qmf PdjUMWb5Ld21PSyCrtGc/hTKwxMoHsOZPy6UB8YJ5omZdsavcjKMrDpybguOfxUmGYs2H3MJ ghIUQMMOe0267uQcmMNDPRueGWTLXcuyz0Tpe62Whekc3gNMl0JrNz6Gty8OBb/ETijfSHPE qGHYuyAZJo9A/IazHuJ+4n+gm4kQl1WLfxoRMzYHCA== In-Reply-To: <20250320185238.447458-29-jim.cromie@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduiedtudduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefkffggfgfhuffvvehfjggtgfesthekredttddvjeenucfhrhhomhepnfhouhhishcuvehhrghuvhgvthcuoehlohhuihhsrdgthhgruhhvvghtsegsohhothhlihhnrdgtohhmqeenucggtffrrghtthgvrhhnpeetfffhtdeigfehffduuedvkeefgfdvuddugfffteetffdvteffgfejvedugffgffenucffohhmrghinhepsghoohhtlhhinhdrtghomhenucfkphepledtrdekledrudeifedruddvjeenucevlhhushhtvghrufhiiigvpeegnecurfgrrhgrmhepihhnvghtpeeltddrkeelrdduieefrdduvdejpdhhvghloheplgduledvrdduieekrddtrddvtdgnpdhmrghilhhfrhhomheplhhouhhishdrtghhrghuvhgvthessghoohhtlhhinhdrtghomhdpnhgspghrtghpthhtohepudegpdhrtghpthhtohepjhhimhdrtghrohhmihgvsehgmhgrihhlrdgtohhmpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtohepughrihdquggvvhgvlheslhhishhtshdrfhhrvggvuggvshhkthhophdrohhrghdprhgtphhtthhopegrmhguqdhgfhigsehlihhsthhsr dhfrhgvvgguvghskhhtohhprdhorhhgpdhrtghpthhtohepihhnthgvlhdqghhvthdquggvvheslhhishhtshdrfhhrvggvuggvshhkthhophdrohhrghdprhgtphhtthhopehinhhtvghlqdhgfhigsehlihhsthhsrdhfrhgvvgguvghskhhtohhprdhorhhgpdhrtghpthhtohepihhnthgvlhdqghhfgidqthhrhigsohhtsehlihhsthhsrdhfrhgvvgguvghskhhtohhprdhorhhgpdhrtghpthhtohepjhgsrghrohhnsegrkhgrmhgrihdrtghomh X-GND-Sasl: louis.chauvet@bootlin.com Le 20/03/2025 à 19:52, Jim Cromie a écrit : > This new test-fn runs 3 module/submodule modprobe scenarios, variously > using both the generic dyndbg= modprobe arg, and the > test-module's classmap-params to manipulate the test-mod*'s pr_debugs. > In all cases, the current flag-settings are counted and tested vs > expectations. > > The 3rd scenario recapitulates the DRM_USE_DYNAMIC_DEBUG=y failure. > > 1. 2 modprobes (super then sub), with separate dyndbg=class-settings > check module specific flag settings > > 2. modprobe submod, supermod is auto-loaded > set supermod class-params > check expected enablements in super & submod > > 3. modprobe super, with param=setting (like drm.debug=0x1ef) > modprobe submod > validate submod's class'd pr_debugs get properly enabled > > The test uses multi-queries, with both commas and percents (to avoid > spaces and quoting). This is the main reason the test wasn't earlier > in the patchset, closer to the classmap patches its validating. > > With some tedium, the tests could be refactored to split out early > tests which avoid multi-cmds, and test only the class-params. > > Signed-off-by: Jim Cromie Reviewed-by: Louis Chauvet > --- > - drop -v used in test_mod_submod(). V=1 does it for whole test > - ifrmmod at test end (Lukasz) > --- > .../dynamic_debug/dyndbg_selftest.sh | 69 +++++++++++++++++++ > 1 file changed, 69 insertions(+) > > diff --git a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh > index c97c9391d0f4..cfed79b34996 100755 > --- a/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh > +++ b/tools/testing/selftests/dynamic_debug/dyndbg_selftest.sh > @@ -275,10 +275,79 @@ function test_percent_splitting { > ifrmmod test_dynamic_debug > } > > +function test_mod_submod { > + echo -e "${GREEN}# TEST_MOD_SUBMOD ${NC}" > + ifrmmod test_dynamic_debug_submod > + ifrmmod test_dynamic_debug > + ddcmd =_ > + > + # modprobe with class enablements > + modprobe test_dynamic_debug \ > + dyndbg=class,D2_CORE,+pf%class,D2_KMS,+pt%class,D2_ATOMIC,+pm > + > + check_match_ct '\[test_dynamic_debug\]' 23 -r > + check_match_ct =pf 1 > + check_match_ct =pt 1 > + check_match_ct =pm 1 > + > + modprobe test_dynamic_debug_submod > + check_match_ct test_dynamic_debug_submod 23 -r > + check_match_ct '\[test_dynamic_debug\]' 23 -r > + check_match_ct test_dynamic_debug 46 -r > + > + # no enablements propagate here > + check_match_ct =pf 1 > + check_match_ct =pt 1 > + check_match_ct =pm 1 > + > + # change classes again, this time submod too > + ddcmd class,D2_CORE,+mf%class,D2_KMS,+lt%class,D2_ATOMIC,+ml "# add some prefixes" > + check_match_ct =pmf 1 > + check_match_ct =plt 1 > + check_match_ct =pml 1 > + # submod changed too > + check_match_ct =mf 1 > + check_match_ct =lt 1 > + check_match_ct =ml 1 > + > + # now work the classmap-params > + # fresh start, to clear all above flags (test-fn limits) > + ifrmmod test_dynamic_debug_submod > + ifrmmod test_dynamic_debug > + modprobe test_dynamic_debug_submod # get supermod too > + > + echo 1 > /sys/module/test_dynamic_debug/parameters/p_disjoint_bits > + echo 4 > /sys/module/test_dynamic_debug/parameters/p_level_num > + # 2 mods * ( V1-3 + D2_CORE ) > + check_match_ct =p 8 > + echo 3 > /sys/module/test_dynamic_debug/parameters/p_disjoint_bits > + echo 0 > /sys/module/test_dynamic_debug/parameters/p_level_num > + # 2 mods * ( D2_CORE, D2_DRIVER ) > + check_match_ct =p 4 > + echo 0x16 > /sys/module/test_dynamic_debug/parameters/p_disjoint_bits > + echo 0 > /sys/module/test_dynamic_debug/parameters/p_level_num > + # 2 mods * ( D2_DRIVER, D2_KMS, D2_ATOMIC ) > + check_match_ct =p 6 > + > + # recap DRM_USE_DYNAMIC_DEBUG regression > + ifrmmod test_dynamic_debug_submod > + ifrmmod test_dynamic_debug > + # set super-mod params > + modprobe test_dynamic_debug p_disjoint_bits=0x16 p_level_num=5 > + check_match_ct =p 7 > + modprobe test_dynamic_debug_submod > + # see them picked up by submod > + check_match_ct =p 14 > + ifrmmod test_dynamic_debug_submod > + ifrmmod test_dynamic_debug > +} > + > tests_list=( > basic_tests > + # these require test_dynamic_debug*.ko > comma_terminator_tests > test_percent_splitting > + test_mod_submod > ) > > # Run tests -- Louis Chauvet, Bootlin Embedded Linux and Kernel engineering https://bootlin.com