From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FEA433F36E for ; Tue, 27 Jan 2026 10:30:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769509846; cv=none; b=e0xi/RBlOTIrOtug/loVV0IPPINp91X9+8ZN9KN2QjK+9g2PiOh6pw2r/Lt3Iqj+8LzOn+RTbX4gxJFkZTGvUtmq9DvJ0AfuKdYil5Dh71TpaIngw3jiawcJ9v2ctQQneAr1EpG1nKwjLUeLN/8l8fpeY08sp8F5swAyEUrWW5g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769509846; c=relaxed/simple; bh=bCw5C2opoTnnSgm6sgEB3kbYxO2Va8uD0u/a6U9QAIo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rxvZFfHeNlzOrRFCu/L3GXSPkBMBlci+vlFDjBMALK3BrmFpBk6uaKMbHHNS7hbEh5WMg1Fl1o/S3/0tWYJEqAyU60v+Md6C0l1eqjSEnG4FVLgso6AFy5OmnPFyf0cHOwQhu3Ih7cII0bkuc5yyIMRbip4XHFUThhqN7uR4lCM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LTLwNie5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZX5WtoPS; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LTLwNie5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZX5WtoPS" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60R9h9vR786620 for ; Tue, 27 Jan 2026 10:30:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BZYKX34HbyGd3trz45+xdQmtQY+aPDvL9EcsqKfZ20s=; b=LTLwNie5R4NqQDe2 D3C0VRXvK5iU8BwLWbYW8e4NTK+9jKG/6gqgcuimZEOAzcbVzlcabXRext/nK7MI +dX9NkbojnDUeo87cho2BUcoAR0+n5ubZjmhkr2wwL/40A1hfTODaESb2w7ksexk UFhZs3IE2BiBkCN/OkIv9JkU4WE+VSLReh4JR3X0QbiNEdxY7K05VC/Obw3tYFiN iPsFNTiiX9y65LA0nT3nYnOgd2L+UmVdFM+xv2OpMXr9DVF7SeXAUWj25/dC1OR2 0YTwF/V/CGBVICOzbsfkE521NNwY1QCckE3PuN/ixZD4DSIZpXgSoLvdqmqme/oH VKNNuA== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bxg93j7rs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 27 Jan 2026 10:30:44 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-88a49b46380so15965016d6.2 for ; Tue, 27 Jan 2026 02:30:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769509843; x=1770114643; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BZYKX34HbyGd3trz45+xdQmtQY+aPDvL9EcsqKfZ20s=; b=ZX5WtoPSekSqnEEaQhnqcwnLrdO+xIw8MrZG5ygTEsyzenxSKJlF37WFdkGpNe9FQP CSDaC68pqkNdgdjg6XU54hmZt0p73iZ2gA/Z5bzCzQqW5UhvIhfJmH/8XbSlxSAg234S 5kKurJzNx9XUdmOzhfuFXPjxf4N4+EuLOz1aDN//0ha4bnOlyUDqyWmx9iO2Zc1lO7qf lC8tmBpBLyI7S3YVF6k8YPMnSgBTJehdMrdRFXp1hV/xCfjP9mCSium7hKaQR1/5il95 teV1UsmPB8wb+cpI+XSM+ChpUgHWj9ZehmIZbY4L2/GaqX51wh0OZWM+Ne83hMriXJkG J+LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769509843; x=1770114643; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BZYKX34HbyGd3trz45+xdQmtQY+aPDvL9EcsqKfZ20s=; b=VRJVN+Lw/XfasRq9KfyFAO2WM9FBH4exOxoKJR1TRe3YGALmETcwtS8gAqt99onJim DUP+CH6CHNsjarM61yVNyjsWLqAtKskTnmZAaoYQHFzIPHx5O6xWQFp1YdGFD/gXshB6 IK19GunKooV0IjKiQB+CdE7VjovQ8LcyRtUZXEkG53vxdXmAuK7p1rWiwLESNTKqNr7A 3SbiwGPeQFhX+v85Wq9BD/MqWLrlVFxZlRlPiN8AuZoTc342RDLrxNfZjAA8n3/t1SRh gwm7sXeHPNvrzj7qcOgnmW4FSB8JUagqcVZNEUS0Nbv6VR/1FDr/PqQrcNgT3kFnEKV0 E9ZA== X-Gm-Message-State: AOJu0YyQ5aAmE63ivI2Uc+vWEST073ryA3wLxQ1C43H1pi0j27Z3NzJ0 palQlGDkPuYMvFw7jLa0JhEMWKrC3G6dTAIYFlmuP8S4PSkq9xkjR/byaq5KWgchkwhucHnDwkd d8kMKz1GmR6I9JjN1T+ylIODy6ePCd3hmic/jeoIny+Iyj1IzFEm3dFiKWQuU7Hpo8KM= X-Gm-Gg: AZuq6aL0A+db9N+gyh7NCuYhmAH4rhzB0u/+XWfDZ+vW/rEYGGJpUTdRTFiIstv1tsx HMvSvjoU1rF+p4tPFynyyCe/hxIsT/jRzMbyQh092OrCAukm4ajcgA8sv1Dw2CIXI4aRFvVdCw2 5R5CpR+wgFeypIdXrFf8qKElnDr5xqYQTsgd18MmwPjqmjM7+GdGz5mr0ww1xpduyNA989UDaD7 Rs8AWNtFMQeikzXDxSWSYO/yhWskMvWLMoJ6l+GuUArUoIfkZWvv1Xw6xoS5gcCDzuS/NmbAPV7 /Qeduh9ZyJYvkdNrJVQFZExqP9EyuuN0LDE6b7BvbAv2ED0R1yqd2m/WD48KnQWVHelkyENxZD0 2Rf2YKxlmnsGu2brM3rCnP8wrGpf74zBXOKFYAxAJiGOmVuSHpnojMlaMt/uR70EKOHM= X-Received: by 2002:ac8:5988:0:b0:4f1:b3c0:2ae7 with SMTP id d75a77b69052e-5032f9f14c7mr9458361cf.6.1769509843463; Tue, 27 Jan 2026 02:30:43 -0800 (PST) X-Received: by 2002:ac8:5988:0:b0:4f1:b3c0:2ae7 with SMTP id d75a77b69052e-5032f9f14c7mr9458111cf.6.1769509843081; Tue, 27 Jan 2026 02:30:43 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6584b3ea422sm6007927a12.10.2026.01.27.02.30.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jan 2026 02:30:42 -0800 (PST) Message-ID: <80e774c9-c4b7-4129-aed4-17830377bd61@oss.qualcomm.com> Date: Tue, 27 Jan 2026 11:30:40 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 3/7] qcom-tgu: Add signal priority support To: Songwei Chai , andersson@kernel.org, alexander.shishkin@linux.intel.com, mike.leach@linaro.org, suzuki.poulose@arm.com, james.clark@arm.com, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org, devicetree@vger.kernel.org, gregkh@linuxfoundation.org References: <20260109021141.3778421-1-songwei.chai@oss.qualcomm.com> <20260109021141.3778421-4-songwei.chai@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI3MDA4NSBTYWx0ZWRfXy1ypABgzvWoY c/rQQyM8utiOhYAsX4h0CkXtbUJQxjWCGs9+PgYGA05bXUv/r+FYY7pSlst0pSDFP3yRdiVX/VI 4MEiGirMPE6r7h2Wsnoy4MwZrAoClJ4Ds7vr3SmXEVdA+tDgZyy/IASLfLfaiAOyikO0boKb12z 1lhLQa2xI6HuHLdPrefzXTFGyG14QP7T8h3k8jWZLNUc+mTWWhZxbKF02K+xXskjp2UNJHbvW5j VRjp/9yxOfodZlz4Lsni8gY/vb6smnHK/2IDve+q+Y/3gPu9wzCIeSGq5c5Kkw2FRy2ICsXe+IH BHeeKvncOOJ9XaGBcOzzV64SLRpePP//DDyqWD2XJ/RNvQBrNzEtRPha5aCxAYiSOBHj+YLw0cX EInW1SThUxcUvgcHoGfSJkrMCrU0HjYJ/T45c3KpPF9R0Nk2zeJTbvfbuHPc2Nff3i5JsNepZEi vCaYs76hanMH7xyV9PA== X-Authority-Analysis: v=2.4 cv=Uc1ciaSN c=1 sm=1 tr=0 ts=697893d4 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=Vvjh0lqrh_H4iIbA9MMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-ORIG-GUID: _h4ZzZG0RMrVxgBU3AaWvJdHAgNXzyq1 X-Proofpoint-GUID: _h4ZzZG0RMrVxgBU3AaWvJdHAgNXzyq1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-27_02,2026-01-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 malwarescore=0 phishscore=0 spamscore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601270085 On 1/27/26 3:23 AM, Songwei Chai wrote: > > > On 1/13/2026 7:09 PM, Konrad Dybcio wrote: >> On 1/9/26 3:11 AM, Songwei Chai wrote: >>> Like circuit of a Logic analyzer, in TGU, the requirement could be >>> configured in each step and the trigger will be created once the >>> requirements are met. Add priority functionality here to sort the >>> signals into different priorities. The signal which is wanted could >>> be configured in each step's priority node, the larger number means >>> the higher priority and the signal with higher priority will be sensed >>> more preferentially. >>> >>> Signed-off-by: Songwei Chai >>> --- [...] >>> +    if (tgu_attr->step_index < drvdata->max_step) { >>> +        ret = (tgu_attr->reg_num < drvdata->max_reg) ? >>> +            attr->mode : 0; >>> +    } >>> +    return ret; >> >> This is very convoluted >> >> How about: >> >> if (tgu_attr->step_index >= drvdata->max_step) >>     return 0; >> >> if (tgu_attr->reg_num >= drvdata->max_reg) >>     return 0; >> >> return attr->mode; >> >> ? >> >> [...] >> > I agree that the expanded form is clearer step-by-step, but I intentionally kept the current version as it keeps the bounds checks localized and avoids multiple early returns in this simple case. Multiple early returns are not an anti-pattern to avoid Konrad