From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932239AbcEWM1Q (ORCPT ); Mon, 23 May 2016 08:27:16 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:36618 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755289AbcEWM1M (ORCPT ); Mon, 23 May 2016 08:27:12 -0400 Subject: Re: [PATCH] KVM: Unify traced vector format To: Jan Kiszka , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= References: <5742A695.2090707@siemens.com> Cc: kvm , Linux Kernel Mailing List From: Paolo Bonzini Message-ID: <80e89f04-73d2-db95-8359-40c8d539a67f@redhat.com> Date: Mon, 23 May 2016 14:26:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <5742A695.2090707@siemens.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/05/2016 08:43, Jan Kiszka wrote: > Specifically the change from hex to decimal helps correlating events. > > Signed-off-by: Jan Kiszka > --- > include/trace/events/kvm.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/trace/events/kvm.h b/include/trace/events/kvm.h > index 526fb3d..f28292d 100644 > --- a/include/trace/events/kvm.h > +++ b/include/trace/events/kvm.h > @@ -108,7 +108,7 @@ TRACE_EVENT(kvm_ioapic_set_irq, > __entry->coalesced = coalesced; > ), > > - TP_printk("pin %u dst %x vec=%u (%s|%s|%s%s)%s", > + TP_printk("pin %u dst %x vec %u (%s|%s|%s%s)%s", > __entry->pin, (u8)(__entry->e >> 56), (u8)__entry->e, > __print_symbolic((__entry->e >> 8 & 0x7), kvm_deliver_mode), > (__entry->e & (1<<11)) ? "logical" : "physical", > @@ -129,7 +129,7 @@ TRACE_EVENT(kvm_ioapic_delayed_eoi_inj, > __entry->e = e; > ), > > - TP_printk("dst %x vec=%u (%s|%s|%s%s)", > + TP_printk("dst %x vec %u (%s|%s|%s%s)", > (u8)(__entry->e >> 56), (u8)__entry->e, > __print_symbolic((__entry->e >> 8 & 0x7), kvm_deliver_mode), > (__entry->e & (1<<11)) ? "logical" : "physical", > @@ -151,7 +151,7 @@ TRACE_EVENT(kvm_msi_set_irq, > __entry->data = data; > ), > > - TP_printk("dst %u vec %x (%s|%s|%s%s)", > + TP_printk("dst %u vec %u (%s|%s|%s%s)", > (u8)(__entry->address >> 12), (u8)__entry->data, > __print_symbolic((__entry->data >> 8 & 0x7), kvm_deliver_mode), > (__entry->address & (1<<2)) ? "logical" : "physical", > Looks good, thanks. Paolo