From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: Omar Sandoval <osandov@fb.com>
Cc: syzbot <syzbot+b382ba6a802a3d242790@syzkaller.appspotmail.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
syzkaller-bugs@googlegroups.com, viro@zeniv.linux.org.uk,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jens Axboe <axboe@fb.com>
Subject: Re: BUG: unable to handle kernel paging request in dput (2)
Date: Wed, 30 Jan 2019 20:11:17 +0900 [thread overview]
Message-ID: <80e90ecd-77f5-00a3-4e91-5e9eea2aa117@I-love.SAKURA.ne.jp> (raw)
In-Reply-To: <00000000000081e6cc0580aa76a2@google.com>
Hello, Omar.
syzbot is reporting a crash due to dput(-EINVAL) [1]. I think the location is
dir = debugfs_lookup(buts->name, blk_debugfs_root);
if (!dir)
bt->dir = dir = debugfs_create_dir(buts->name, blk_debugfs_root);
added by commit 6ac93117ab009d39 ("blktrace: use existing disk debugfs directory").
Currently, Greg Kroah-Hartman is posting patches:
When calling debugfs functions, there is no need to ever check the
return value. The function can work or not, but the code logic should
never do something different based on this.
Omar, what do you want to do for this case?
[1] https://syzkaller.appspot.com/bug?extid=b382ba6a802a3d242790
next prev parent reply other threads:[~2019-01-30 11:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 10:35 syzbot
2019-01-30 11:11 ` Tetsuo Handa [this message]
2019-01-30 11:23 ` Greg Kroah-Hartman
2019-01-30 11:26 ` Tetsuo Handa
2019-01-30 11:34 ` Greg Kroah-Hartman
2019-01-30 11:40 ` Greg Kroah-Hartman
2019-01-31 10:09 ` Kees Cook
2019-01-31 10:18 ` Tetsuo Handa
2019-01-31 10:53 ` Greg Kroah-Hartman
2019-01-30 11:20 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80e90ecd-77f5-00a3-4e91-5e9eea2aa117@I-love.SAKURA.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=axboe@fb.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=osandov@fb.com \
--cc=syzbot+b382ba6a802a3d242790@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®