From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934571AbcLBOhI (ORCPT ); Fri, 2 Dec 2016 09:37:08 -0500 Received: from lelnx194.ext.ti.com ([198.47.27.80]:27536 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751451AbcLBOgU (ORCPT ); Fri, 2 Dec 2016 09:36:20 -0500 Subject: Re: [PATCH] net: phy: dp83848: Support ethernet pause frames To: Jesper Nilsson , Florian Fainelli References: <20161202142203.GY19016@axis.com> CC: Roger Quadros , "David S. Miller" , Dan Murphy , , From: "Andrew F. Davis" Message-ID: <80ee8058-7d6b-ea88-7ec6-20daf50a1fce@ti.com> Date: Fri, 2 Dec 2016 08:35:23 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161202142203.GY19016@axis.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/02/2016 08:22 AM, Jesper Nilsson wrote: > According to the documentation, the PHYs supported by this driver > can also support pause frames. Announce this to be so. > Tested with a TI83822I. > Looks like all PHYs supported by this driver do, so: Acked-by: Andrew F. Davis > Signed-off-by: Jesper Nilsson > --- > drivers/net/phy/dp83848.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/phy/dp83848.c b/drivers/net/phy/dp83848.c > index 800b39f..6e4117f 100644 > --- a/drivers/net/phy/dp83848.c > +++ b/drivers/net/phy/dp83848.c > @@ -88,7 +88,8 @@ MODULE_DEVICE_TABLE(mdio, dp83848_tbl); > .phy_id = _id, \ > .phy_id_mask = 0xfffffff0, \ > .name = _name, \ > - .features = PHY_BASIC_FEATURES, \ > + .features = (PHY_BASIC_FEATURES | \ > + SUPPORTED_Pause | SUPPORTED_Asym_Pause),\ Aligning these may look nicer though. > .flags = PHY_HAS_INTERRUPT, \ > \ > .soft_reset = genphy_soft_reset, \ >