mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Cercueil <paul@crapouillou.net>
To: Guanglei Zhu <zhugl3@xiaopeng.com>,
	Harvey Hunt <harveyhuntnexus@gmail.com>,
	 Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
		linux-mips@vger.kernel.org, linux-mtd@lists.infradead.org,
		linux-kernel@vger.kernel.org, Weibin Liu <liuwb@xiaopeng.com>
Subject: Re: [PATCH v2 2/2] mtd: rawnand: ingenic: validate BCH error index in jz4780_correct()
Date: Tue, 17 Nov 2026 15:22:10 +0100	[thread overview]
Message-ID: <80f1ef9dd605d16df2add0a9dbdcdd5f9f508174.camel@crapouillou.net> (raw)
In-Reply-To: <20261105042405.71352-2-zhugl3@xiaopeng.com>

Hi Zhu,

Le jeudi 05 novembre 2026 à 12:24 +0800, Guanglei Zhu a écrit :
> From: Weibin Liu <liuwb@xiaopeng.com>
> 
> The JZ4780 BCH controller reports each corrected bit error as a byte
> pair index, in the INDEX field of the BCH_BHERR registers. The field
> is 11 bits wide, but nothing in jz4780_correct() checks the reported
> index against the size of the data buffer being corrected:
> 
>     buf[(index * 2) + 0] ^= mask;
>     buf[(index * 2) + 1] ^= mask >> 8;
> 
> With data or ECC coming from an untrusted flash, the decoder can
> report an index that points past the end of the data buffer, and the
> above statements then flip bits outside the buffer.
> 
> Skip the correction when the reported index does not point into
> the data area.  A bitflip in the parity bytes does not affect the
> data, so rejecting the page for it would fail reads that are
> perfectly correctable, and an index beyond the codeword has no
> buffer to update in the first place.
> 
> Fixes: ae02ab00aa3c ("mtd: nand: jz4780: driver for NAND devices on JZ4780
> SoCs")
> Signed-off-by: Weibin Liu <liuwb@xiaopeng.com>

Since you have a Fixes: tag, you also need to Cc: stable@vger.kernel.org

You also need to add your own Signed-off-by alongside Liu's, since you sent the
patch.

The change looks good to me, so you can add my:
Reviewed-by: Paul Cercueil <paul@crapouillou.net>

Please send a v3 with the Cc: line, your own Signed-off-by, and my Reviewed-by.

Cheers,
-Paul

> ---
> Changes in v2: skip the correction for an index that does not point
> into the data area instead of failing the page with -EBADMSG.  A
> correctable bitflip in the ECC bytes leaves the data valid, and the
> early exit also dropped the error entries that followed it.  This
> matches how jz4740_ecc_correct() treats its indexes.
> 
> Verified with a userspace replica of the correction loop: with
> params->size = 512, an index of 256 (first parity word) or at the
> field maximum (0x7ff) produces no write outside the data buffer,
> and in-range indexes keep correcting as before.
> 
>  drivers/mtd/nand/raw/ingenic/jz4780_bch.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/mtd/nand/raw/ingenic/jz4780_bch.c
> b/drivers/mtd/nand/raw/ingenic/jz4780_bch.c
> index 12b5b0484fe9..3a4c5d6e7f8a 100644
> --- a/drivers/mtd/nand/raw/ingenic/jz4780_bch.c
> +++ b/drivers/mtd/nand/raw/ingenic/jz4780_bch.c
> @@ -216,6 +216,10 @@ static int jz4780_correct(struct ingenic_ecc *bch,
>  						BCH_BHERR_MASK_SHIFT;
>  			index = (reg & BCH_BHERR_INDEX_MASK) >>
>  						BCH_BHERR_INDEX_SHIFT;
> +			/* Skip indexes outside the data area. */
> +			if ((index * 2) + 1 >= params->size)
> +				continue;
> +
>  			buf[(index * 2) + 0] ^= mask;
>  			buf[(index * 2) + 1] ^= mask >> 8;
>  		}

  reply	other threads:[~2026-11-17 14:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05  4:01 [PATCH 1/2] mtd: rawnand: ingenic: validate BCH error index in jz4725b_correct() Guanglei Zhu
2026-11-05  4:01 ` [PATCH 2/2] mtd: rawnand: ingenic: validate BCH error index in jz4780_correct() Guanglei Zhu
2026-11-05  4:24 ` [PATCH v2 1/2] mtd: rawnand: ingenic: validate BCH error index in jz4725b_correct() Guanglei Zhu
2026-11-05  4:24   ` [PATCH v2 2/2] mtd: rawnand: ingenic: validate BCH error index in jz4780_correct() Guanglei Zhu
2026-11-17 14:22     ` Paul Cercueil [this message]
2026-11-06 14:37   ` [PATCH v2 1/2] mtd: rawnand: ingenic: validate BCH error index in jz4725b_correct() Paul Cercueil
2026-11-16 17:06     ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80f1ef9dd605d16df2add0a9dbdcdd5f9f508174.camel@crapouillou.net \
    --to=paul@crapouillou.net \
    --cc=harveyhuntnexus@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=liuwb@xiaopeng.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    --cc=zhugl3@xiaopeng.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®