From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Atish Patra <atishp@atishpatra.org>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
Atish Patra <atish.patra@wdc.com>,
linux-riscv <linux-riscv@lists.infradead.org>,
Palmer Dabbelt <palmerdabbelt@google.com>,
"linux-kernel@vger.kernel.org List"
<linux-kernel@vger.kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>
Subject: Re: [PATCH -next] RISCV: Add some depends for NUMA
Date: Thu, 4 Feb 2021 17:17:34 +0800 [thread overview]
Message-ID: <80f2821a-1c08-ce16-b7a9-7d2debc7f16e@huawei.com> (raw)
In-Reply-To: <CAOnJCULd0=FoQjorjmz6EVB7_YphjGBwUCuY+ntOP6JiUb4P6w@mail.gmail.com>
On 2021/2/4 3:59, Atish Patra wrote:
> On Wed, Feb 3, 2021 at 6:20 AM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>> The numa feature is useless for riscv32 platform(MAXPHYSMEM_1GB if 32bit),
>> and it should depends on SMP feature, this also fix the build error,
>>
>> riscv64-buildroot-linux-gnu-ld: mm/page_alloc.o: in function `.L0 ':
>> page_alloc.c:(.text+0x4808): undefined reference to `node_reclaim_distance'
>>
> Thanks for the fix. The commit text is a bit ambiguous. The
> compilation issue error is due to SMP.
> RV32 dependency is just another fix as NUMA is not very useful for RV32.
Yes, the two depends fix different issue，the lack of SMP leads to the
compilation issue, another
depend is to remove support on RV32.
Thanks for your review, if necessary, I could resend with changelog
updated.
> Reviewed-by: Atish Patra <atish.patra@wdc.com>
next prev parent reply other threads:[~2021-02-04 9:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 14:23 Kefeng Wang
2021-02-03 19:59 ` Atish Patra
2021-02-04 9:17 ` Kefeng Wang [this message]
2021-02-05 6:58 ` Palmer Dabbelt
2021-02-05 7:53 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80f2821a-1c08-ce16-b7a9-7d2debc7f16e@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=atish.patra@wdc.com \
--cc=atishp@atishpatra.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=palmerdabbelt@google.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®