From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53BF025F994 for ; Fri, 5 Jun 2026 04:19:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780633180; cv=none; b=Owlq/B6g20VY3nLwYaCDMkjv9eaQN/fiZP/p7QO8AYURHi87dVz/GzlCuC7zM8zxYeXMgHf9x5kzuPFm4S5UgafdcZOWG7ySDFhuUXnGb5FVe9JKgDonnGVSSEM678O1aWTtxjuLNSPcD45d6za8fyf1Cy2wExnfE2K2EHzH3q0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780633180; c=relaxed/simple; bh=P0k3sjK1cy2s+oAAkkB7A+jj3/4HX1PN8oxb5Y7vg4E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VG7Kr8kMmyIS8F8jQ3UKzr5DlUxRZKh5AtyiQxupiGuz//PGmbaAvHjHjgMk73IXq0Cv5fZ1jiXDopdOgI5AATfmmE7BoVjoo4nzIN3EWeEzy+Na8okweN32CfTImQhXJfMcIDrfxZwxP5bHHP0ZUfSSNCDLmc613a5CnUnleq4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mhjLCCft; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NdNY4aiY; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mhjLCCft"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NdNY4aiY" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6553TdNI944530 for ; Fri, 5 Jun 2026 04:19:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5vRZHUtGWFFmC5/cs/BfJ9BpSx9TWoNBXHZpysMZMUw=; b=mhjLCCftqmNzP3xN plYV/tWVes2Whw70oXGGJOOTbQFPUn95wRQuZJE6e1V0bSOGVKDyTSpEb2UccgEw DIcCYBtYuNQSrEJ9Zz6XLWZjJWBynUw2lR1yxIptXbI9Bqkn4rNhyPWltfDwTYK6 GM1b5Orykfi2pgexWYwhSYxhUGDcCPOG6v7j97IcQylhtL8coJig/cctaleJT27w /OCUT9weFSmitBXKbRI+1tHjUBPkp76hvmsd08P2rxQYeBaNtU+gj+EGul9xHKa7 R7VqwxxUmpQ8qnGXZtTK4VHUNzOOql1m03SqdIFH+HjzILHBdpuZ8CLBjbtyAcZ+ PJAmwQ== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ek8d542b3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 05 Jun 2026 04:19:38 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-842208d5b0eso1044925b3a.3 for ; Thu, 04 Jun 2026 21:19:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780633178; x=1781237978; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5vRZHUtGWFFmC5/cs/BfJ9BpSx9TWoNBXHZpysMZMUw=; b=NdNY4aiYwx2bfVjtqD5JfrUzwBf4vH4r04EWJG0DKp+lmXti0tQ1vQVUdHkERJN1R5 cbluqnnEOR1SYYoKeiz/LFBz+Hz0b8ejiyBzsmwugZ3b2vZu+4ge/YnLQ+xKz3fiPxEL 0H592cD654aJgX3ePMlIxbWHSJMDhOhsKF+Z3kiOYD5+NvZbCzknreHiRcmWvdPKSIUl iHgW3GpkDUPbgC86AtWA9wCg+pyaSZGf0SHSRRGHczh8Xhvpfbr452iTxO7QrE95IHZ4 607KHPjhz0OwAOf+aEXH10v9xuxcufGeGZa4A8cHEcoQ3fofHOS8eHmDOIPzzDysCV0K 6v2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780633178; x=1781237978; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5vRZHUtGWFFmC5/cs/BfJ9BpSx9TWoNBXHZpysMZMUw=; b=eFOs9/hpkdKMH8MeaWPq1ykxxdsN30TRyZv7QajC+6Zzv7pjI8oxKEULlbccq8f0hi pUEGE91sGFL6sLRv/NIJ8A7y/zuW+YZFgOAh7ZHz4W2HG2O33YmMcTjiBE/Qvi/sbaeP SICpbbEgh3eFU7XKw6RLkMu6ItgIbL05/9fSL7JS6+LdJwV9OuMyy6A1hjGMkF1A45vQ r9mPvT1zLtOfYILdW3FATQMv9zRdxITxn1xGtfwVW6ehrcb1trh3cMvtHdAKfFIyMwww Wng1xPnGPvSxiFh+pkYMkPFUVCbNMkVujpIIdQ8CQcDMebeHwVNXf416G1T050Ofvv/W IPrw== X-Forwarded-Encrypted: i=1; AFNElJ8GTn3QAOll6szJxh+FrYLoeEUGo/6k3FLcJ+Y15cWyzOFbIvOWQIMGJkPaWIOj1Ra+lGhN7TKensVRtu4=@vger.kernel.org X-Gm-Message-State: AOJu0YzOJyVtRMUDYPylQ5rjhQRftjPKkL/CTxP2Eoamz2IjpeDf4YQi DBzn3s3ITv8EBtJhrklOuM0FWMVTo5f7yo0kDHfdAh8XS++S9bMPe8s7+df3kFWDgiCEyUdkbG1 u8pIVsw2bX73D048Nygq55bS7TFDI3YY24vPwYlVw4mwnrWsUMcp8Jkp7UrpHLNqjpePGlplEbl 4= X-Gm-Gg: Acq92OFk30V4PFnUEoEnRUXvCftog1nxMWM+pXno/33HSG83Yl0NdpD1omEjkG5/Sqz loTr7Z+DVbiMItLzJ4qqZUlHPvin0gmKpVbZicKD9+B8pLWA67orVtwy9hYkZtfIS2wz+/4IGrv Qe60cd/gZoWboJZ0qaGZELGz6lJQ6wMz1jd7ejRZ5JC+ITZJrHLmGw97Yp0qymWDglGYAiG/kex D24uKQjZfRWoqmlLCVQi15ha7K7eLrWPX3gqh22wX5B4mlJdCOe5hGdETpc4upBU5nEpT63dujQ B6TVdRyc7YbeirQR19fbXUl1mwYVbzkfxgj9Y9eK1CPmr5cIxv8RWA9IeF9IpNQEw9I/YRppZAO behh5oBOeleA+HkJRzwp6MRXu3+KwLm2bD/NoiGhNeuqP6fF0Y562fVCtZqcP/Vue27HjMA== X-Received: by 2002:a05:6a00:420c:b0:842:5b63:6116 with SMTP id d2e1a72fcca58-842b0f1ed2emr1678150b3a.7.1780633177782; Thu, 04 Jun 2026 21:19:37 -0700 (PDT) X-Received: by 2002:a05:6a00:420c:b0:842:5b63:6116 with SMTP id d2e1a72fcca58-842b0f1ed2emr1678114b3a.7.1780633177311; Thu, 04 Jun 2026 21:19:37 -0700 (PDT) Received: from [10.151.36.45] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8428221c3e4sm8007058b3a.5.2026.06.04.21.19.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jun 2026 21:19:35 -0700 (PDT) Message-ID: <80fa8c92-e426-4bc7-ad1f-b0be0f405506@oss.qualcomm.com> Date: Fri, 5 Jun 2026 09:49:30 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 1/1] remoteproc: qcom: Add NOTIFY_FATAL event type to SSR subdevice To: Jeff Johnson , Gokul Sriram Palanisamy , andersson@kernel.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: quic_varada@quicinc.com, quic_srichara@quicinc.com, quic_viswanat@quicinc.com, quic_mojha@quicinc.com, aaradhana.sahu@oss.qualcomm.com References: <20240820060943.277260-1-quic_gokulsri@quicinc.com> <9d3728cf-bf4b-4ba0-8c71-831d908072a9@oss.qualcomm.com> Content-Language: en-US From: Vignesh Viswanathan In-Reply-To: <9d3728cf-bf4b-4ba0-8c71-831d908072a9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: QtzNCgbX6e1FQiXSs4bWT5FHnY2gQ6i6 X-Authority-Analysis: v=2.4 cv=IZG3n2qa c=1 sm=1 tr=0 ts=6a224e5a cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=COk6AnOGAAAA:8 a=rz8_RQ3GBV-xKMBrbdQA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA1MDAzOCBTYWx0ZWRfXxyEBuBBYLZVB so8ek3K30j7uXoDPHjh81iYDGczIwxlVHm9+ayBLgSaLs4BX/WDinGNUR8Yve6xvabI0egdQ0Ap trHclJPtZch8SATmrSZZva88CUhgumMkxvoNIzwmdUIjbrblEC02m88Ge67MeFBrsVxfg7cqJRT lmhuHdUndZKcFXrklfrd3v8SPasGU1ZhkNCInlovCuTTTy70vP7szcUyOHCtlFPVV8qVWzxkpDy oTnP0GX92FTpUebHX5S/Isfee/ilBD/M2mpdII14I51vWWTg0ouuCY4XF3F6ZQww5kvrgBYfh/f odWazjCGOitCtXN8hpDPjeWbRY8V//lmEJCOFvRTPeBCwF3GHqyUxhM2NfJgtmXXAoy+7gf9OKC aOhZyPkPsinMblZergdIK9kKd8zedKOG8chLaY+iKwOb7C0D7eHYVv+/ITynFXbBEtL/cUqAh4C IhWW9m/JGnihdaukczw== X-Proofpoint-GUID: QtzNCgbX6e1FQiXSs4bWT5FHnY2gQ6i6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-04_07,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 malwarescore=0 phishscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606050038 On 6/5/2026 2:32 AM, Jeff Johnson wrote: > On 8/19/2024 11:09 PM, Gokul Sriram Palanisamy wrote: >> From: Vignesh Viswanathan >> >> Currently the SSR subdevice notifies the client driver on crash of the >> rproc from the recovery workqueue using the BEFORE_SHUTDOWN event. >> However, the client driver might be interested to know that the device >> has crashed immediately to pause any further transactions with the >> rproc. This calls for an event to be sent to the driver in the IRQ >> context as soon as the rproc crashes. >> >> Add NOTIFY_FATAL event to SSR subdevice to atomically notify rproc has > > Almost 2 years later and I'm finally seeing the ath12k patch in internal > review that uses this. > > I was confused when the ath12k code didn't actually have any references to > "NOTIFY_FATAL" and then I got a build error due to a missing > QCOM_SSR_NOTIFY_CRASH. > > So all instance of NOTIFY_FATAL in the subject and commit text should be > changed to NOTIFY_CRASH. > > And as was noted by Dmitry, this patch should be packaged with the ath12k > patch when it leaves internal review. Agreed Jeff, I'll rebase this patch and change NOTIFY_FATAL to NOTIFY_CRASH and send out a v2 for internal review. Thanks, Vignesh > >