From: Krzysztof Kozlowski <krzk@kernel.org>
To: Frank Li <Frank.li@nxp.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<imx@lists.linux.dev>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] arm64: dts: imx93: add lpi2c1 and child node
Date: Sun, 4 Aug 2024 10:33:57 +0200 [thread overview]
Message-ID: <80fd755e-071e-44d3-a3b9-6ca16e97a447@kernel.org> (raw)
In-Reply-To: <Zqztwh3yghN8Drnj@lizhi-Precision-Tower-5810>
On 02/08/2024 16:31, Frank Li wrote:
> On Fri, Aug 02, 2024 at 09:25:54AM +0200, Krzysztof Kozlowski wrote:
>> On 01/08/2024 18:09, Frank Li wrote:
>>> From: Clark Wang <xiaoning.wang@nxp.com>
>>>
>>> Add lpi2c1 and child node for imx93-11x11-evk board.
>>
>> Why? What for? What are these? We see all this from the diff, so commit
>> msg should explain why and what do you want to achieve.
>
> I really don't know how to explain why/what for these straing forward
> thing, hardware board has such component, just add it dts file.
You can explain what you are adding in terms of hardware. "child node"
is really useless description.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-08-04 8:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 16:09 Frank Li
2024-08-02 7:25 ` Krzysztof Kozlowski
2024-08-02 14:31 ` Frank Li
2024-08-02 16:49 ` Stefan Wahren
2024-08-04 8:33 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80fd755e-071e-44d3-a3b9-6ca16e97a447@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®