From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26795EB64DC for ; Mon, 10 Jul 2023 21:00:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232295AbjGJVAK (ORCPT ); Mon, 10 Jul 2023 17:00:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229811AbjGJVAI (ORCPT ); Mon, 10 Jul 2023 17:00:08 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76786BC; Mon, 10 Jul 2023 14:00:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=BDD/kXWc4mPL62yQdsd+c6fXt0hPTnce16m0rj/81RY=; b=htzTmXFD7JiauLShb4XitpCS7w 8NrlOm226PO1pz5G3bLJvyCbiln5ayI37MwfM0Hlxv5GtdEs/BEbG3SMdvf7W49J0cAJHGB+Qov8N 6X3B4ngIwTRf9a8XHDcbk+upAESwIj9sCqT1VI2OV4Be4akMyftOG3HM/0gGYGDB3eXs=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qIxyx-000z3A-MY; Mon, 10 Jul 2023 22:59:43 +0200 Date: Mon, 10 Jul 2023 22:59:43 +0200 From: Andrew Lunn To: Andrew Halaney Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org, mcoquelin.stm32@gmail.com, pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, joabreu@synopsys.com, alexandre.torgue@foss.st.com, peppe.cavallaro@st.com, bhupesh.sharma@linaro.org, vkoul@kernel.org, linux-arm-msm@vger.kernel.org, simon.horman@corigine.com Subject: Re: [PATCH net-next v2 1/3] net: stmmac: dwmac-qcom-ethqos: Use of_get_phy_mode() over device_get_phy_mode() Message-ID: <80fe2a99-67fd-4c8f-86c8-b097faa8be31@lunn.ch> References: <20230710201636.200412-1-ahalaney@redhat.com> <20230710201636.200412-2-ahalaney@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230710201636.200412-2-ahalaney@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 10, 2023 at 03:06:37PM -0500, Andrew Halaney wrote: > Since this driver only uses devicetree, let's move over to > of_get_phy_mode(). That API has an explicit error return and produces a > phy_interface_t directly instead of an int when representing the phy > mode. > > Signed-off-by: Andrew Halaney Reviewed-by: Andrew Lunn Andrew