From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59DD4200DD; Sun, 10 Mar 2024 18:52:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710096736; cv=none; b=jBqHRVYIRl1+Ojv3mkCma2jke1h4nQ14fsSEd60sghKjKs7ofakwblFoiK/Zty6guRp9+UXQhsuI362HuSueXZlQauxBhHON0Rw21ybT4dQ+/IraJGLarf8XXFtTusJ6TD3yieaGb3U/6ef6oxv9GAXrnKQl8FgEUJwojxKthAI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710096736; c=relaxed/simple; bh=PyiE+eMguPww4jANk/vO3f+RJgxXzpz5Dw9mnlTNxAA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lw6KwchZI2jado+W+AWj4EpyPlD//3l3e1kHOIEpL2yfAlhtm7NZJZNa5g8+EfMGIHHl7emFmqtvnora12X8wInH/xI52FL87rzg1peLXfeFDLgusLO8eHr4lpd9PnReeod62jD3UrUl47my/hnZuMOLNUUKL8dp/0bXT0v/nVI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=LWuDYglI; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="LWuDYglI" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=uNlaw3g4wwBNanhEYw5cc+Vm2nzhdvAOPOMqtxqaW2M=; b=LWuDYglIL+fPB5EYJ0AyIE9GwB QQlTloupfzxxQJPXhTjHdk9jh3sMuF1HZRbbvIqb/Sw30LU7rVwZQVxCmM6iMqmuST2Ghuje/w7zn O51SbDiu1a0QhQMN/Pr9M7QQzWY5mSdSge2/JB0wSNR8gzr2/L+FGJI4LeKKPo2L6Ds8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rjOHn-009v7h-7U; Sun, 10 Mar 2024 19:52:39 +0100 Date: Sun, 10 Mar 2024 19:52:39 +0100 From: Andrew Lunn To: Luiz Angelo Daros de Luca Cc: Linus Walleij , Alvin =?utf-8?Q?=C5=A0ipraga?= , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH net-next 1/4] dt-bindings: net: dsa: realtek: describe LED usage Message-ID: <80fee2d0-356b-4baf-bd7a-b338df3644fa@lunn.ch> References: <20240310-realtek-led-v1-0-4d9813ce938e@gmail.com> <20240310-realtek-led-v1-1-4d9813ce938e@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240310-realtek-led-v1-1-4d9813ce938e@gmail.com> > + properties: > + reg: > + description: > + "reg indicates the LED group for this LED" > + enum: [0, 1, 2, 3] Having read the code, i don't think the binding needs to say anything about the group. It is implicit. Port LED 0 is in group 0. Port LED 1 is in group 1. So there is nothing here which is outside of the standard LED binding. So as Linus said, i don't think you need any YAML at all, the DSA port binding should be sufficient. Andrew