From: Guenter Roeck <linux@roeck-us.net>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Jean Delvare <jdelvare@suse.com>, Frank Li <Frank.Li@nxp.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: tmp108: fix I3C dependency
Date: Wed, 13 Nov 2024 12:04:26 -0800 [thread overview]
Message-ID: <8104966f-8e46-47b8-9e20-acefb667b5cf@roeck-us.net> (raw)
In-Reply-To: <20241113175615.2442851-1-arnd@kernel.org>
On Wed, Nov 13, 2024 at 06:55:33PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> It's possible to build a kernel with tmp108 built-in but i3c support
> in a loadable module, but that results in a link failure:
>
> x86_64-linux-ld: drivers/hwmon/tmp108.o: in function `p3t1085_i3c_probe':
> tmp108.c:(.text+0x5f9): undefined reference to `i3cdev_to_dev'
>
> Add a Kconfig dependency to ensure only the working configurations
> are allowed.
>
> Fixes: c40655e33106 ("hwmon: (tmp108) Add support for I3C device")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
I knew I missed something ;-).
Thanks a lot for the patch. Applied.
Guenter
prev parent reply other threads:[~2024-11-13 20:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 17:55 Arnd Bergmann
2024-11-13 20:04 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8104966f-8e46-47b8-9e20-acefb667b5cf@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Frank.Li@nxp.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®