From: Ashutosh Naik <ashutosh.naik@gmail.com>
To: linux-scsi@vger.kernel.org, James.Bottomley@steeleye.com,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] scsi/pcmcia/fdomain_stub.c: Handle scsi_add_host failure
Date: Tue, 10 Jan 2006 18:28:39 +0530 [thread overview]
Message-ID: <81083a450601100458u683a3d57g8fb74ebe06c4f2b4@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 151 bytes --]
Add scsi_add_host() failure handling for the Future Domain-compatible
PCMCIA SCSI driver.
Signed-off-by: Ashutosh Naik <ashutosh.naik@gmail.com>
[-- Attachment #2: pcmcia-fdomain.txt --]
[-- Type: text/plain, Size: 931 bytes --]
diff -Naurp linux-2.6.15-git5-vanilla/drivers/scsi/pcmcia/fdomain_stub.c linux-2.6.15-git5/drivers/scsi/pcmcia/fdomain_stub.c
--- linux-2.6.15-git5-vanilla/drivers/scsi/pcmcia/fdomain_stub.c 2006-01-10 16:24:06.000000000 +0530
+++ linux-2.6.15-git5/drivers/scsi/pcmcia/fdomain_stub.c 2006-01-10 18:17:47.000000000 +0530
@@ -143,6 +143,7 @@ static void fdomain_config(dev_link_t *l
u_char tuple_data[64];
char str[16];
struct Scsi_Host *host;
+ int retval;
DEBUG(0, "fdomain_config(0x%p)\n", link);
@@ -188,7 +189,13 @@ static void fdomain_config(dev_link_t *l
goto cs_failed;
}
- scsi_add_host(host, NULL); /* XXX handle failure */
+ retval = scsi_add_host(host, NULL);
+ if (retval) {
+ printk(KERN_WARNING "fdomain_cs: scsi_add_host failed\n");
+ scsi_host_put(host);
+ return retval;
+ }
+
scsi_scan_host(host);
sprintf(info->node.dev_name, "scsi%d", host->host_no);
next reply other threads:[~2006-01-10 12:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-10 12:58 Ashutosh Naik [this message]
2006-01-13 18:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81083a450601100458u683a3d57g8fb74ebe06c4f2b4@mail.gmail.com \
--to=ashutosh.naik@gmail.com \
--cc=James.Bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®