Re: [PATCH]ibft: Fix the display of a few fields in the NIC attribute structure in sysfs

[Ashutosh Naik <ashutosh.naik@gmail.com>]

On Thu, Apr 16, 2009 at 3:07 AM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Sun, 12 Apr 2009 09:06:59 -0400
> Konrad Rzeszutek <ketuzsezr@darnok.org> wrote:
>
>> > The second question is who picks this up?  The drivers/firmware
>> > directory doesn't seem to have a dedicated tree, so I can take this
>> > through the SCSI tree if required or Andrew can take it through -mm.
>>
>> Which way works best for everybody? I was thinking SCSI, since the end result
>> of this module is to configure the storage used to bootstrap the box.
>
> I can merge merge it later this week.
>
> However...
>
>
> : From: Ashutosh Naik <ashutosh.naik@gmail.com>
> :
> : Fix the display of a few fields in the iBFT NIC attribute structure in
> : sysfs.
<snip>

> The changelog is bad.
>
> What does "fix" mean?  What does the old output look like and how does
> this patch change it?
>
> This matters, because this is a userspace interface and who knows, there
> might be applications out there which somehow depend on the old and
> broken behaviour.
>
> Of course, that might be totally silly and unrealistic but because we
> weren't told what the patch actually does, how can I tell?
>
> Please send a new and complete description of this change, thanks.

Sorry for the delay.

Here is an updated Changelog

The patch ensures that on, if the DHCP