From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCD27C433E2 for ; Fri, 17 Jul 2020 05:03:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8FC1820684 for ; Fri, 17 Jul 2020 05:03:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726734AbgGQFD3 (ORCPT ); Fri, 17 Jul 2020 01:03:29 -0400 Received: from foss.arm.com ([217.140.110.172]:33466 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725811AbgGQFD3 (ORCPT ); Fri, 17 Jul 2020 01:03:29 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 874B730E; Thu, 16 Jul 2020 22:03:28 -0700 (PDT) Received: from [10.163.88.185] (unknown [10.163.88.185]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9217E3F66E; Thu, 16 Jul 2020 22:03:23 -0700 (PDT) Subject: Re: [PATCH v3] mm/hugetlb: split hugetlb_cma in nodes with memory To: Mike Kravetz , Will Deacon , Roman Gushchin Cc: Barry Song , Catalin Marinas , x86@kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, linux-mm@kvack.org, Ingo Molnar , Thomas Gleixner , Jonathan Cameron , "H.Peter Anvin" , Borislav Petkov , akpm@linux-foundation.org, Mike Rapoport , linux-arm-kernel@lists.infradead.org References: <20200710120950.37716-1-song.bao.hua@hisilicon.com> <359ea1d0-b1fd-d09f-d28a-a44655834277@oracle.com> <20200715081822.GA5683@willie-the-truck> <5724f1f8-63a6-ee0f-018c-06fb259b6290@oracle.com> <20200716081243.GA6561@willie-the-truck> From: Anshuman Khandual Message-ID: <81103d30-f4fd-8807-03f9-d131da5097bd@arm.com> Date: Fri, 17 Jul 2020 10:32:53 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/16/2020 11:55 PM, Mike Kravetz wrote: >>>From 17c8f37afbf42fe7412e6eebb3619c6e0b7e1c3c Mon Sep 17 00:00:00 2001 > From: Mike Kravetz > Date: Tue, 14 Jul 2020 15:54:46 -0700 > Subject: [PATCH] hugetlb: move cma reservation to code setting up gigantic > hstate > > Instead of calling hugetlb_cma_reserve() directly from arch specific > code, call from hugetlb_add_hstate when adding a gigantic hstate. > hugetlb_add_hstate is either called from arch specific huge page setup, > or as the result of hugetlb command line processing. In either case, > this is late enough in the init process that all numa memory information > should be initialized. And, it is early enough to still use early > memory allocator. This assumes that hugetlb_add_hstate() is called from the arch code at the right point in time for the generic HugeTLB to do the required CMA reservation which is not ideal. I guess it must have been a reason why CMA reservation should always called by the platform code which knows the boot sequence timing better.